Skip to content

Move streamToUint8Array back to node-web-streams-helper.ts#92263

Merged
ztanner merged 4 commits into
canaryfrom
04-02-move_streamtouint8array_back_to_node-web-streams-helper.ts
Apr 3, 2026
Merged

Move streamToUint8Array back to node-web-streams-helper.ts#92263
ztanner merged 4 commits into
canaryfrom
04-02-move_streamtouint8array_back_to_node-web-streams-helper.ts

Conversation

@timneutkens
Copy link
Copy Markdown
Contributor

@timneutkens timneutkens commented Apr 2, 2026 •
edited
Loading

What?

Fixes the case where having React 18 installed fails the build because react-dom gets imported from stream-ops. #90500 moved the streamToUint8Array from node-web-streams-helper to stream-ops. This moves the function back to where it was before.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. type: next labels Apr 2, 2026
@timneutkens Graphite App
Copy link
Copy Markdown
Contributor Author

timneutkens commented Apr 2, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@timneutkens timneutkens marked this pull request as ready for review April 2, 2026 14:34
@nextjs-bot
Copy link
Copy Markdown
Contributor

nextjs-bot commented Apr 2, 2026 •
edited
Loading

Tests Passed

@nextjs-bot
Copy link
Copy Markdown
Contributor

nextjs-bot commented Apr 2, 2026 •
edited
Loading

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
node_modules Size 487 MB 487 MB 🔴 +81.8 kB (+0%) ▁▁▁▁▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 434ms 434ms ✓ ▁▁▁▁▁
Cold (First Request) 1.936s 1.904s ✓ ▃▂▃▂▂
Warm (Listen) 456ms 455ms ✓ ▁▁▁▁▁
Warm (Ready in log) 432ms 434ms ✓ ▁▁▁▁▁
Warm (First Request) 1.931s 1.934s ✓ ▂▂▃▂▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.187s 14.262s ✓ ▁▁▁▁▁
Cached Build 14.363s 14.483s ✓ ▁▁▁▁▁
node_modules Size 487 MB 487 MB 🔴 +81.8 kB (+0%) ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 60.7 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.8 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 254 B ✓
main-HASH.js gzip 39.3 kB 39.2 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.8 kB -
9544-HASH.js gzip N/A 61.4 kB -
Total 235 kB 235 kB ⚠️ +649 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 126 kB ✓
page.js gzip 273 kB 273 kB ✓
Total 398 kB 398 kB ⚠️ +126 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 615 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 44.3 kB 44.1 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.9 kB 45.7 kB ✅ -187 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.36 MB 4.36 MB ✓
index.pack gzip 110 kB 112 kB 🔴 +2 kB (+2%)
index.pack.old gzip 110 kB 110 kB ✓
Total 4.58 MB 4.58 MB ⚠️ +4.34 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 342 kB 342 kB ✓
app-page-exp..prod.js gzip 189 kB 189 kB ✓
app-page-tur...dev.js gzip 341 kB 341 kB ✓
app-page-tur..prod.js gzip 189 kB 189 kB ✓
app-page-tur...dev.js gzip 338 kB 338 kB ✓
app-page-tur..prod.js gzip 187 kB 187 kB ✓
app-page.run...dev.js gzip 338 kB 338 kB ✓
app-page.run..prod.js gzip 187 kB 187 kB ✓
app-route-ex...dev.js gzip 76.6 kB 76.6 kB ✓
app-route-ex..prod.js gzip 52.2 kB 52.2 kB ✓
app-route-tu...dev.js gzip 76.6 kB 76.6 kB ✓
app-route-tu..prod.js gzip 52.2 kB 52.2 kB ✓
app-route-tu...dev.js gzip 76.2 kB 76.2 kB ✓
app-route-tu..prod.js gzip 52 kB 52 kB ✓
app-route.ru...dev.js gzip 76.2 kB 76.2 kB ✓
app-route.ru..prod.js gzip 52 kB 52 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.8 kB 43.8 kB ✓
pages-api-tu..prod.js gzip 33.4 kB 33.4 kB ✓
pages-api.ru...dev.js gzip 43.8 kB 43.8 kB ✓
pages-api.ru..prod.js gzip 33.4 kB 33.4 kB ✓
pages-turbo....dev.js gzip 53.2 kB 53.2 kB ✓
pages-turbo...prod.js gzip 39 kB 39 kB ✓
pages.runtim...dev.js gzip 53.2 kB 53.2 kB ✓
pages.runtim..prod.js gzip 39 kB 39 kB ✓
server.runti..prod.js gzip 62.8 kB 62.8 kB ✓
Total 3.03 MB 3.03 MB ✅ -317 B
📝 Changed Files (17 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • app-route-ex..ntime.dev.js
  • app-route-ex..time.prod.js
  • app-route.runtime.dev.js
  • app-route.ru..time.prod.js
  • pages-api.runtime.dev.js
  • pages-api.ru..time.prod.js
  • pages.runtime.dev.js
  • pages.runtime.prod.js
  • server.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js 
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js 
failed to diff
app-page.runtime.prod.js

Diff too large to display

app-route-ex..ntime.dev.js

Diff too large to display

app-route-ex..time.prod.js

Diff too large to display

app-route.runtime.dev.js

Diff too large to display

app-route.ru..time.prod.js

Diff too large to display

pages-api.runtime.dev.js

Diff too large to display

pages-api.ru..time.prod.js

Diff too large to display

pages.runtime.dev.js

Diff too large to display

pages.runtime.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/eb69d554bf342f8b2a6bc1dea9a6964dffef0d56/next

@timneutkens timneutkens force-pushed the 04-02-move_streamtouint8array_back_to_node-web-streams-helper.ts branch from 69bf7b6 to eb69d55 Compare April 3, 2026 15:50
@ztanner ztanner merged commit ff7cd1b into canary Apr 3, 2026
444 of 460 checks passed
@ztanner ztanner deleted the 04-02-move_streamtouint8array_back_to_node-web-streams-helper.ts branch April 3, 2026 18:55
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ztanner ztanner ztanner approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked run-react-18-tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timneutkens @nextjs-bot @ztanner