[test] Stop using baseUrl#92469
Merged
mischnic merged 2 commits intoApr 13, 2026
Merged
Conversation
This was referenced Apr 7, 2026
Member
Author
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| 'utf8' | ||
| ) | ||
|
|
||
| const typescriptVersion = testBaseUrl ? '5.9.3' : 'latest' |
Contributor
There was a problem hiding this comment.
Test variants for "without baseUrl" still use a tsconfig with baseUrl, making them functionally identical to the "with baseUrl" variants and not testing the intended scenario.
Member
Author
There was a problem hiding this comment.
That's outdated. Not sure why GitHub doesn't display it as such.
1 task
Base automatically changed from
sebbie/04-07-_test_stop_using_compileroptions_that_were_deprecated_in_typescript_6.0
to
canary
April 9, 2026 12:20
eps1lon
added
CI Bypass Graphite Optimization
eps1lon
force-pushed
the
sebbie/04-07-_test_run_alias_suites_with_and_without_baseurl_in_tsconfig.json_
branch
from
d99ce98 to
9bf01ce
Compare
Contributor
Tests Passed |
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
eps1lon
force-pushed
the
graphite-base/92469
branch
from
5e29cec to
c830576
Compare
eps1lon
force-pushed
the
sebbie/04-07-_test_run_alias_suites_with_and_without_baseurl_in_tsconfig.json_
branch
from
9bf01ce to
847843e
Compare
eps1lon
force-pushed
the
sebbie/04-07-_test_run_alias_suites_with_and_without_baseurl_in_tsconfig.json_
branch
3 times, most recently
from
7248214 to
ba4c6c7
Compare
eps1lon
changed the title
baseUrl in tsconfig.jsonbaseUrl
eps1lon
force-pushed
the
sebbie/04-07-_test_run_alias_suites_with_and_without_baseurl_in_tsconfig.json_
branch
from
ba4c6c7 to
6a888d7
Compare
This was referenced Apr 11, 2026
eps1lon
force-pushed
the
sebbie/04-07-_test_run_alias_suites_with_and_without_baseurl_in_tsconfig.json_
branch
from
2da2c98 to
d8462d7
Compare
These tests don't seem to explicitly test `baseUrl` but features relying on behavior of `baseUrl` that can also be covered with just `paths`
eps1lon
force-pushed
the
sebbie/04-07-_test_run_alias_suites_with_and_without_baseurl_in_tsconfig.json_
branch
from
d8462d7 to
3a648f4
Compare
mischnic
approved these changes
Apr 13, 2026
mischnic
deleted the
sebbie/04-07-_test_run_alias_suites_with_and_without_baseurl_in_tsconfig.json_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
baseUrlis deprecated. This PR removes it from tests that don't explicitly testbaseUrlresolution. Tests that relied onbaseUrlwere migrated to usepaths. Tests specifically forbaseUrlwere migrated in #92277 to use TypeScript 5.9.