Exclude trace files from directory deletion in builds#92486
Merged
Conversation
instead just truncate when opening them in builds
Contributor
Tests Passed |
nextjs-bot
added
created-by: Turbopack team
bgw
approved these changes
Apr 13, 2026
Contributor
Author
Merge activity
|
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, open file handles lock files — if the trace write stream happened to be open during
cleanDistDir, deleting{distDir}/tracewould fail withEPERM/EBUSY.TBH: because we batch writes to the file this basically shouldn't happen, but this approach is much clearer.
Two changes:
trace*files from thecleanDistDirdeletion (alongsidecache,dev,lock), so the clean step never races with an open write stream.flags: 'w'(truncate) for production builds so each build gets a fresh trace file, and'a'(append) for dev so traces accumulate across hot reloads.Fixes #92298.