[test] Harden temporary test fixture installs against supply chain attacks#92565
Closed
eps1lon wants to merge 2 commits into
Closed
[test] Harden temporary test fixture installs against supply chain attacks#92565eps1lon wants to merge 2 commits into
eps1lon wants to merge 2 commits into
Conversation
Contributor
Failing test suitesCommit: 7d733ba | About building and testing Next.js
Expand output● pnpm-workspace-root › should not have multiple lockfiles warning when pnpm-workspace.yaml is present |
Member
Author
|
A lot of work to make this work with tests having a custom monorepo-ish setup. I won't spend more time on this. |
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We set
minimumReleaseAgein our monorepo but that's already secured against unintentional upgrades to compromised packages with a lockfile. However, test fixture installs are open since they don't have a lockfile.We now propagate
minimumReleaseAge,minimumReleaseAgeExclude, andblockExoticSubdeps. This doesn't apply to tests using other package managers with a custominstallCommand.