Skip to content

Turbopack: properly set NODE_ENV for SWC plugins #92579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mischnic merged 3 commits into from
Apr 15, 2026
Merged

Turbopack: properly set NODE_ENV for SWC plugins #92579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b50eb18
Fix Turbopack passing "development" to SWC plugins during production …
mischnic Apr 9, 2026
38e498f
CompileTimeDefines::read_process_env
mischnic Apr 13, 2026
4db4292
add test
mischnic Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/next-core/src/segment_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,9 @@ pub async fn parse_segment_config_from_source(
EcmascriptModuleAssetType::Ecmascript
},
EcmascriptInputTransforms::empty(),
// node_env is not used here: EcmascriptInputTransforms::empty() means no
// transforms are applied, so TransformContext::node_env is never accessed.
rcstr!("development"),
false,
false,
)
Expand Down
7 changes: 7 additions & 0 deletions test/e2e/swc-plugins-env/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export default function Root({ children }: { children: React.ReactNode }) {
return (
<html lang="en">
<body>{children}</body>
</html>
)
}
6 changes: 6 additions & 0 deletions test/e2e/swc-plugins-env/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// ENV_CHECK will be replaced by the SWC plugin with "development" or "production"
declare const ENV_CHECK: string

export default function Home() {
return <main>The SWC plugin received env={ENV_CHECK}</main>
}
18 changes: 18 additions & 0 deletions test/e2e/swc-plugins-env/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { nextTestSetup } from 'e2e-utils'

describe('swc-plugins-env', () => {
const { next, skipped, isNextDev } = nextTestSetup({
files: __dirname,
skipDeployment: true,
})
if (skipped) return

it('should pass correct environment to swc plugins', async () => {
const $ = await next.render$('/')
if (isNextDev) {
expect($('main').text()).toBe('The SWC plugin received env=development')
} else {
expect($('main').text()).toBe('The SWC plugin received env=production')
}
})
})
6 changes: 6 additions & 0 deletions test/e2e/swc-plugins-env/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/** @type {import('next').NextConfig} */
module.exports = {
experimental: {
swcPlugins: [['./swc_plugin_env_check.wasm', {}]],
},
}
Loading
Loading