Turbopack: fix filesystem watcher config not applying follow_symlinks(false)#92631
Merged
Conversation
The notify Config uses a builder pattern where with_follow_symlinks() returns a new Config, but the return value was being discarded. Additionally, the RecommendedWatcher branch was passing Config::default() instead of the configured config object. Co-Authored-By: Claude <noreply@anthropic.com>
nextjs-bot
added
created-by: Turbopack team
Merging this PR will improve performance by 3.54%
Performance Changes
Comparing 
Footnotes
|
Contributor
Author
|
im going to extend the hmr-symlink test |
mischnic
changed the title
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (8 files)Files with changes:
View diffspages-api-tu..ntime.dev.jsDiff too large to display pages-api-tu..time.prod.jsDiff too large to display pages-api.runtime.dev.jsDiff too large to display pages-api.ru..time.prod.jsDiff too large to display pages-turbo...ntime.dev.jsDiff too large to display pages-turbo...time.prod.jsDiff too large to display pages.runtime.dev.jsDiff too large to display pages.runtime.prod.jsDiff too large to display 📎 Tarball URL |
Contributor
Author
Merge activity
|
lukesandberg
added a commit
to lukesandberg/notify
that referenced
this pull request
Apr 11, 2026
Otherwise callers might accidentally assume they are mutating e.g. vercel/next.js#92631 fixed a long standing bug in next.js because we failed to capture this return value
JohnTitor
pushed a commit
to notify-rs/notify
that referenced
this pull request
Apr 11, 2026
* Add `must_use` annotation to config builder methods Otherwise callers might accidentally assume they are mutating e.g. vercel/next.js#92631 fixed a long standing bug in next.js because we failed to capture this return value * fix changelog
bgw
pushed a commit
that referenced
this pull request
Apr 13, 2026
…(false) (#92631) ## Summary - The notify `Config` uses a builder pattern where `with_follow_symlinks()` consumes `self` and returns a new `Config`, but the return value was being discarded — so `follow_symlinks` remained at its default (`true`). - The `RecommendedWatcher` branch was also passing `Config::default()` instead of the configured `config` object, ignoring the config entirely. ## Test plan - [x] `cargo check -p turbo-tasks-fs` passes - Behavioral: symlinks under the watched root will now trigger events for the symlink itself rather than the target, matching the intent of the existing comment. <!-- NEXT_JS_LLM_PR -->
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configuses a builder pattern wherewith_follow_symlinks()consumesselfand returns a newConfig, but the return value was being discarded — sofollow_symlinksremained at its default (true).RecommendedWatcherbranch was also passingConfig::default()instead of the configuredconfigobject, ignoring the config entirely.Test plan
cargo check -p turbo-tasks-fspasses