Fix devlow-bench: tsconfig rootDir mismatch with package.json bin#92800
Merged
Conversation
mmastrac
force-pushed
the
mmastrac/fix-devlow-bench
branch
from
72bc4af to
11e0c39
Compare
mmastrac
force-pushed
the
mmastrac/fix-devlow-bench
branch
5 times, most recently
from
0201ad9 to
9ca435b
Compare
mmastrac
force-pushed
the
mmastrac/fix-devlow-bench
branch
from
9ca435b to
31cf5f9
Compare
Contributor
Tests Passed |
mmastrac
force-pushed
the
mmastrac/fix-devlow-bench
branch
from
31cf5f9 to
12d0870
Compare
…/cli.js The bin entry in package.json points to dist/cli.js, but with rootDir: '.' tsc outputs to dist/src/cli.js. The placeholder stub created by pnpm:devPreinstall at dist/cli.js was never overwritten by the build, and turbo cached it as part of dist/**. Change rootDir to 'src' so tsc outputs directly to dist/cli.js.
mmastrac
force-pushed
the
mmastrac/fix-devlow-bench
branch
from
12d0870 to
6e27c4e
Compare
mmastrac
changed the title
bgw
approved these changes
Apr 14, 2026
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Change
rootDirfrom"."to"src"inturbopack/packages/devlow-bench/tsconfig.json.Why
The
binentry inpackage.jsonpoints todist/cli.js. WithrootDir: ".",tscoutputssrc/cli.ts→dist/src/cli.js— the bin path is never produced by the build.The
pnpm:devPreinstallhook (from #91016) creates a placeholder stub atdist/cli.js. Since the build never overwrites it, turbo caches the placeholder as part ofdist/**. On subsequent runs, turbo restores the cached placeholder, and devlow-bench fails with "Local workspace has not been built yet."How
One-line change:
rootDir: "."→rootDir: "src". Nowtscoutputssrc/cli.ts→dist/cli.js, matching thebinentry. The placeholder gets properly overwritten by the build.