Skip to content

Fix monorepo @next/swc binary postinstall#92813

Merged
eps1lon merged 2 commits into
canaryfrom
sebbie/04-15-fix_monorepo_postinstall_next/swc_binary_install
Apr 15, 2026
Merged

Fix monorepo @next/swc binary postinstall#92813
eps1lon merged 2 commits into
canaryfrom
sebbie/04-15-fix_monorepo_postinstall_next/swc_binary_install

Conversation

@eps1lon
Copy link
Copy Markdown
Member

@eps1lon eps1lon commented Apr 15, 2026

Same issue as in #92568 but here we can actually forward all the security related settigns.

We now also fail postinstall if the binary install fails so that errors aren't swallowed (pnpm only shows the last 10 or so lines of stdout of postinstall).

eps1lon added 2 commits April 15, 2026 11:01
If we exit successfully, pnpm will collapse stdout/stderr
from the postinstall script hiding relevant debug
information. It's unclear why we would ignore these
errors.
@nextjs-bot nextjs-bot added the created-by: Next.js team PRs by the Next.js team. label Apr 15, 2026
@eps1lon eps1lon changed the title Fix monorepo @next/swc binary install Fix monorepo @next/swc binary install Apr 15, 2026
@eps1lon eps1lon requested a review from bgw April 15, 2026 09:03
@eps1lon eps1lon changed the title Fix monorepo @next/swc binary install Fix monorepo @next/swc binary postinstall Apr 15, 2026
@eps1lon eps1lon marked this pull request as ready for review April 15, 2026 09:07
packageManager,
}
fs.writeFileSync(path.join(tmpdir, 'package.json'), JSON.stringify(pkgJson))
fs.writeFileSync(path.join(tmpdir, '.npmrc'), 'node-linker=hoisted')
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved into pnpm-workspace.yaml

@eps1lon eps1lon enabled auto-merge (squash) April 15, 2026 09:43
@eps1lon eps1lon merged commit 6413e52 into canary Apr 15, 2026
328 of 331 checks passed
@eps1lon eps1lon deleted the sebbie/04-15-fix_monorepo_postinstall_next/swc_binary_install branch April 15, 2026 09:47
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Next.js team PRs by the Next.js team. locked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants