Fix monorepo @next/swc binary postinstall#92813
Merged
eps1lon merged 2 commits intoApr 15, 2026
Merged
Conversation
If we exit successfully, pnpm will collapse stdout/stderr from the postinstall script hiding relevant debug information. It's unclear why we would ignore these errors.
@next/swc binary install
@next/swc binary install@next/swc binary postinstall
timneutkens
approved these changes
Apr 15, 2026
eps1lon
commented
Apr 15, 2026
| packageManager, | ||
| } | ||
| fs.writeFileSync(path.join(tmpdir, 'package.json'), JSON.stringify(pkgJson)) | ||
| fs.writeFileSync(path.join(tmpdir, '.npmrc'), 'node-linker=hoisted') |
Member
Author
There was a problem hiding this comment.
Moved into pnpm-workspace.yaml
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same issue as in #92568 but here we can actually forward all the security related settigns.
We now also fail
postinstallif the binary install fails so that errors aren't swallowed (pnpm only shows the last 10 or so lines of stdout of postinstall).