Skip to content

Allow overriding outputHashSalt in modifyConfig#92856

Merged
mischnic merged 2 commits into
canaryfrom
mischnic/salt-adapter
Apr 16, 2026
Merged

Allow overriding outputHashSalt in modifyConfig#92856
mischnic merged 2 commits into
canaryfrom
mischnic/salt-adapter

Conversation

@mischnic
Copy link
Copy Markdown
Member

@mischnic mischnic commented Apr 15, 2026

That hashSalt property copied the value from nextConfig.experimental.outputHashSalt too early. Values assigned by adapters via modifyConfig (which happens after assignDefaultsAndValidate) were ignored.

Instead handle it similarly to what we do for process.env.NEXT_DEPLOYMENT_ID as well

Fixup for #91871

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. tests Turbopack Related to Turbopack with Next.js. type: next labels Apr 15, 2026
@mischnic mischnic changed the title mischnic/salt-adapter Allow overriding outputHashSalt in modifyConfig Apr 15, 2026
Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic requested a review from sokra April 15, 2026 21:33
@mischnic mischnic marked this pull request as ready for review April 15, 2026 21:33
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 15, 2026

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

@mischnic mischnic force-pushed the mischnic/salt-adapter branch from cc0c618 to 6def13d Compare April 15, 2026 21:47
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 15, 2026

Merging this PR will improve performance by 3.58%

⚡ 1 improved benchmark
✅ 16 untouched benchmarks
⏩ 3 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation app-page-turbo.runtime.prod.js[full] 640.9 ms 618.7 ms +3.58%

Comparing mischnic/salt-adapter (6def13d) with canary (bf4de72)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mischnic mischnic merged commit 26cfeb8 into canary Apr 16, 2026
187 of 189 checks passed
@mischnic mischnic deleted the mischnic/salt-adapter branch April 16, 2026 10:43
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Turbopack team PRs by the Turbopack team. locked tests Turbopack Related to Turbopack with Next.js. type: next

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants