[turbopack] fix feature usage telemetry#93100
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lukesandberg
force-pushed
the
more_ineffective_tasks
branch
2 times, most recently
from
80f135b to
905545d
Compare
lukesandberg
force-pushed
the
fix_telemetry
branch
from
15d32a7 to
4d7c6d1
Compare
Merging this PR will degrade performance by 3.4%
Performance Changes
Comparing 
Footnotes
|
lukesandberg
force-pushed
the
more_ineffective_tasks
branch
from
905545d to
e550aff
Compare
lukesandberg
force-pushed
the
fix_telemetry
branch
from
4d7c6d1 to
06b101f
Compare
lukesandberg
commented
Apr 22, 2026
lukesandberg
commented
Apr 22, 2026
lukesandberg
commented
Apr 22, 2026
lukesandberg
commented
Apr 22, 2026
lukesandberg
commented
Apr 22, 2026
lukesandberg
commented
Apr 22, 2026
lukesandberg
commented
Apr 22, 2026
lukesandberg
commented
Apr 22, 2026
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Suggestion:
Test file next-rs-api.test.ts references .diagnostics on TurbopackResult objects, but diagnostics was removed from TurbopackResult in commit 06b101f, causing all diagnostics assertions to fail at runtime (accessing undefined).
lukesandberg
changed the base branch from
more_ineffective_tasks
to
graphite-base/93100
lukesandberg
force-pushed
the
graphite-base/93100
branch
from
e550aff to
157d145
Compare
lukesandberg
force-pushed
the
fix_telemetry
branch
from
06b101f to
f6f1f87
Compare
lukesandberg
changed the base branch from
graphite-base/93100
to
more_ineffective_tasks
github-actions
Bot
added
created-by: Turbopack team
lukesandberg
force-pushed
the
more_ineffective_tasks
branch
from
157d145 to
f579205
Compare
lukesandberg
force-pushed
the
fix_telemetry
branch
from
f6f1f87 to
9c08867
Compare
Contributor
Tests PassedCommit: edc1992 |
lukesandberg
force-pushed
the
fix_telemetry
branch
2 times, most recently
from
6d0776f to
ab525f2
Compare
lukesandberg
force-pushed
the
more_ineffective_tasks
branch
from
19ba862 to
b45210d
Compare
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: b3f4b1f |
lukesandberg
changed the base branch from
more_ineffective_tasks
to
graphite-base/93100
wbinnssmith
approved these changes
May 8, 2026
lukesandberg
force-pushed
the
fix_telemetry
branch
from
ab525f2 to
709bbbe
Compare
lukesandberg
force-pushed
the
graphite-base/93100
branch
from
b45210d to
f0c1ffc
Compare
lukesandberg
force-pushed
the
fix_telemetry
branch
from
709bbbe to
b3f4b1f
Compare
lukesandberg
force-pushed
the
fix_telemetry
branch
from
b3f4b1f to
edc1992
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report Turbopack feature-usage telemetry
Turbopack never reported
NEXT_BUILD_FEATURE_USAGEtelemetry for production builds. This PR wires it up and fixes a correctness bug in how the counts were computed, then cleans up the API surface that carried them across the napi boundary.Changes
turbopackBuild()now recordsEVENT_BUILD_FEATURE_USAGEevents afterwriteAllEntrypointsToDiskvia a neweventBuildFeatureUsageFromTurbopackDiagnosticshelper. Dev is out of scope — webpack'sTelemetryPluginis!dev && isClienttoo.EventBuildFeatureUsage['featureName']union — SWC triple is nowswc/target/<triple>; droppedpersistentCaching(redundant withturbopackFileSystemCache) andturbotrace: false(hardcoded).Correctness fix: count unique importers, not resolves
Previously feature-usage counts for module imports (
next/image,next/font/google, …) were computed from aBeforeResolvePluginthat emitted one event per resolve. Turbopack caches resolves, so the emission fired at most once per unique request — the count was effectively1for every feature that was imported anywhere. Webpack's equivalent counts unique importing modules viamoduleGraph.getIncomingConnections(module).size.This PR replaces the resolve-plugin emission with a single whole-app module-graph traversal on
Project. For each tracked feature, we accumulate the set of unique parent modules of each matching node (mirroring webpack's "unique origin modules" semantics). Fonts are matched against their synthesized/target.css?…virtual modules produced by the SWC font-loader transform — matching webpack'sFEATURE_MODULE_REGEXP_MAPapproach. Paths are matched viaphf_map!tables innext_telemetry.rs.Incidental simplifications
While in here, the
Diagnosticcollectibles subsystem got right-sized and then removed entirely, since feature usage was its only consumer:Project::project_feature_usage()returns a structuredVc<ProjectFeatureUsageSummary>instead of emitting diagnostics. Surfaced to JS as a dedicatedproject.featureUsage(): Promise<BuildFeatureUsage[]>napi method, called once at build's end.TurbopackResult<T>loses itsdiagnostics: BuildFeatureUsage[]field — it's now just{ result, issues }. Every napi result type and ~10 construction sites are correspondingly simpler.turbopack_core::diagnosticsentirely (Diagnostictrait,DiagnosticExt,DiagnosticContextExt,CapturedDiagnostics,PlainBuildFeatureUsage). DeletedFeatureUsageTelemetry,ModuleFeatureReportResolvePlugin,get_diagnostics()aggregation, thefeature_usage/diagnosticsfields onAllWrittenEntrypointsWithIssues/OperationResult/EntrypointsWithIssues/WrittenEndpointWithIssues/HmrUpdateWithIssues/HmrChunkNamesWithIssues/EndpointIssuesAndDiags/WriteAnalyzeResult, and the defensivedrop_collectibles::<Box<dyn Diagnostic>>()scrub inentrypoints_without_collectibles_operation.Feature-usage telemetry now flows as a plain return value end-to-end:
Project::project_feature_usage()→ napiprojectFeatureUsage()→ JSproject.featureUsage()→telemetry.record(). No collectibles, no peeking, no emission-as-side-effect.Tests
Un-skipped four previously webpack-only integration tests in
test/integration/telemetry/test/config.test.ts:image/script/dynamic,next/legacy/image,transpilePackages, and middleware options. All pass under Turbopack. The remaining three skipped tests (swcflags,@vercel/og,useCache) cover features Turbopack doesn't emit yet — left skipped with TODOs.Added unit test for the helper at
packages/next/src/telemetry/events/build.test.ts. Updated the Turbopacknext-rs-apisnapshot to reflect the new diagnostic shape.