Skip to content

patch npm-package-arg to support pnpm catalogs#93224

Closed
lukesandberg wants to merge 3 commits into
canaryfrom
lerna_catalogs
Closed

patch npm-package-arg to support pnpm catalogs#93224
lukesandberg wants to merge 3 commits into
canaryfrom
lerna_catalogs

Conversation

@lukesandberg
Copy link
Copy Markdown
Contributor

@lukesandberg lukesandberg commented Apr 24, 2026 •
edited
Loading

We recently adopted pnpm catalogs to improve our turbo-repo caching (in #93071)

This however breaks lerna which we use for releases. this is because it relies on npm-package-arg which parses versions directly out of package.json files.

This patches npm-package-arg to recover the dependency versions from the pnpm-lock.yml file.

@lukesandberg Graphite App
Copy link
Copy Markdown
Contributor Author

lukesandberg commented Apr 24, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the created-by: Turbopack team PRs by the Turbopack team. label Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change
Cold (Listen) 811ms 811ms ✓
Cold (Ready in log) 793ms 789ms ✓
Cold (First Request) 1.262s 1.268s ✓
Warm (Listen) 811ms 811ms ✓
Warm (Ready in log) 791ms 792ms ✓
Warm (First Request) 614ms 610ms ✓
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change
Cold (Listen) 811ms 810ms ✓
Cold (Ready in log) 787ms 787ms ✓
Cold (First Request) 3.232s 3.233s ✓
Warm (Listen) 811ms 810ms ✓
Warm (Ready in log) 786ms 787ms ✓
Warm (First Request) 3.229s 3.227s ✓

⚡ Production Builds

Metric Canary PR Change
Fresh Build 4.988s 4.972s ✓
Cached Build 4.998s 4.964s ✓
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change
Fresh Build 23.554s 23.560s ✓
Cached Build 23.534s 23.608s ✓
node_modules Size 495 MB 495 MB ✓
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
07rxhp_1_g4mu.js gzip 13.1 kB N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0fli3_wppnim5.js gzip 12.9 kB N/A -
0jaojkrb2rf_l.js gzip 158 B N/A -
0k09jwjeb-tki.js gzip 13.8 kB N/A -
0kb7_ep3r1z0_.js gzip 10.1 kB N/A -
0kw8xgqdrilf6.js gzip 8.56 kB N/A -
0ojkk2e654xsc.js gzip 8.59 kB N/A -
0wxpyd8r-vipl.js gzip 1.47 kB N/A -
0xy2fhla48_rd.js gzip 9.24 kB N/A -
0zg1_op6gpm77.js gzip 159 B N/A -
10u1wg6830n69.js gzip 155 B N/A -
10wqsvi2mgfmi.js gzip 9.82 kB N/A -
16lhqjoqbznyg.js gzip 220 B 220 B ✓
16vepdkipri3r.js gzip 8.51 kB N/A -
17n96uu6y1pxq.js gzip 8.6 kB N/A -
18y4_8-9or0mn.js gzip 8.51 kB N/A -
1ejk4yy877m2s.js gzip 156 B N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1gq145j3kps-h.js gzip 8.62 kB N/A -
1nsh-mbn0e-se.js gzip 8.56 kB N/A -
1o8iht4q821x5.js gzip 49.4 kB N/A -
1tsrrp1tdngti.js gzip 13.3 kB N/A -
1wbblhm8kdg1d.js gzip 70.9 kB N/A -
2__-e_ym8n788.js gzip 450 B N/A -
21h2q5l_ijxo1.js gzip 156 B N/A -
22o6xd9_ywdu6.js gzip 233 B N/A -
25ee1c0k3yry7.js gzip 155 B N/A -
25n272-g99oa1.js gzip 7.61 kB N/A -
2jqyc54izxg_5.js gzip 154 B N/A -
2kvj8yrfznmwx.js gzip 5.69 kB N/A -
2m-x8jeelz1qx.js gzip 169 B N/A -
2qv7m7xjnokgr.js gzip 8.58 kB N/A -
2t9oc38of5_ar.js gzip 153 B N/A -
2zf1ecbz94sp-.js gzip 65.5 kB N/A -
342ijzvrpe53h.js gzip 2.29 kB N/A -
3b0qzjz24jcjn.js gzip 157 B N/A -
3k1k5gtofm6eq.js gzip 10.4 kB N/A -
3m606uqf8ws_m.js gzip 155 B N/A -
3msaeh9eztxfm.js gzip 161 B N/A -
3pgbrgq66slx4.js gzip 155 B N/A -
turbopack-02..a6-3.js gzip 4.19 kB N/A -
turbopack-0b..7ght.js gzip 4.17 kB N/A -
turbopack-19..b8v3.js gzip 4.19 kB N/A -
turbopack-1k..fy7t.js gzip 4.19 kB N/A -
turbopack-1n..nqqb.js gzip 4.2 kB N/A -
turbopack-1z..cxi_.js gzip 4.19 kB N/A -
turbopack-21..uim9.js gzip 4.19 kB N/A -
turbopack-27..jjpo.js gzip 4.19 kB N/A -
turbopack-2m..i5vn.js gzip 4.19 kB N/A -
turbopack-2m..1fe1.js gzip 4.19 kB N/A -
turbopack-2v..1576.js gzip 4.19 kB N/A -
turbopack-33..fmta.js gzip 4.19 kB N/A -
turbopack-3q..h-7b.js gzip 4.19 kB N/A -
turbopack-3u..fo-_.js gzip 4.19 kB N/A -
01ofzfnqdbuen.js gzip N/A 158 B -
0arkbdqpxc37i.js gzip N/A 8.6 kB -
0bz-xifewa17d.js gzip N/A 8.63 kB -
0gh_yv8qw4m5-.js gzip N/A 157 B -
0im0h0br03kar.js gzip N/A 156 B -
0tvekitj587fh.js gzip N/A 8.51 kB -
0yvk6-wi8e9wh.js gzip N/A 13.3 kB -
1-jqyfc89tixo.js gzip N/A 1.46 kB -
10y3h86mnhs_2.js gzip N/A 10.4 kB -
14t1kneseb8th.js gzip N/A 2.3 kB -
15sb1-dsqfk_j.js gzip N/A 8.59 kB -
1ab2xruymo-oj.js gzip N/A 449 B -
1cz0kmzuvr895.js gzip N/A 70.9 kB -
1tu25qtsmfhar.js gzip N/A 9.82 kB -
1vein_gnv3mwr.js gzip N/A 8.56 kB -
1wzrm0xjjbzn5.js gzip N/A 10.1 kB -
1z3g0uaqtv9_3.js gzip N/A 8.56 kB -
25a1yz7zua29z.js gzip N/A 13.8 kB -
2auzvn7t9xf96.js gzip N/A 65.5 kB -
2bi5hx402juv-.js gzip N/A 8.58 kB -
2fiqb4-ar30kx.js gzip N/A 49.4 kB -
2fuln2dxq8d_0.js gzip N/A 154 B -
2hy56297fog9u.js gzip N/A 8.52 kB -
2qd9d0wg7yxwc.js gzip N/A 158 B -
2u_rpxq3tzytl.js gzip N/A 233 B -
2wr55o64ssudv.js gzip N/A 161 B -
2yy2v4vukl6e0.js gzip N/A 161 B -
35-eg4zotgxro.js gzip N/A 157 B -
35nh2lh_i5pyh.js gzip N/A 7.61 kB -
368lim5wq0o0r.js gzip N/A 12.9 kB -
3drqjohogojbw.js gzip N/A 5.69 kB -
3g8l1m2-o-ewi.js gzip N/A 13.1 kB -
3ixmpqnyxmqfs.js gzip N/A 170 B -
3k0wlheipb1ej.js gzip N/A 159 B -
3km28rtkbqo-g.js gzip N/A 158 B -
3n9xy43ds2l11.js gzip N/A 159 B -
3tfgis6xa1unl.js gzip N/A 158 B -
3wpp8nvyoj121.js gzip N/A 9.24 kB -
turbopack-0-..xakf.js gzip N/A 4.19 kB -
turbopack-09..ikej.js gzip N/A 4.19 kB -
turbopack-0j..nybk.js gzip N/A 4.19 kB -
turbopack-0o..1pwm.js gzip N/A 4.21 kB -
turbopack-1m..wh9e.js gzip N/A 4.17 kB -
turbopack-1r..xsvl.js gzip N/A 4.19 kB -
turbopack-1t..xctc.js gzip N/A 4.19 kB -
turbopack-28..ffdj.js gzip N/A 4.19 kB -
turbopack-2k..ao0y.js gzip N/A 4.19 kB -
turbopack-2o..i1c7.js gzip N/A 4.19 kB -
turbopack-2o..wsn2.js gzip N/A 4.19 kB -
turbopack-2t..clq6.js gzip N/A 4.19 kB -
turbopack-35..-wtq.js gzip N/A 4.19 kB -
turbopack-3w..fwa0.js gzip N/A 4.19 kB -
Total 465 kB 465 kB ⚠️ +90 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 721 B 719 B ✓
Total 721 B 719 B ✅ -2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 435 B 433 B ✓
Total 435 B 433 B ✅ -2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2637-HASH.js gzip 4.63 kB N/A -
7724.HASH.js gzip 169 B N/A -
8274-HASH.js gzip 61.3 kB N/A -
8817-HASH.js gzip 5.59 kB N/A -
c3500254-HASH.js gzip 62.8 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 255 B ✓
main-HASH.js gzip 39.4 kB 39.3 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
5887-HASH.js gzip N/A 5.61 kB -
6522-HASH.js gzip N/A 60.6 kB -
6779-HASH.js gzip N/A 4.63 kB -
8854.HASH.js gzip N/A 169 B -
eab920f9-HASH.js gzip N/A 62.8 kB -
Total 235 kB 235 kB ✅ -620 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 333 B 334 B ✓
dynamic-HASH.js gzip 1.81 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 255 B 255 B ✓
head-HASH.js gzip 353 B 349 B 🟢 4 B (-1%)
hooks-HASH.js gzip 384 B 382 B ✓
image-HASH.js gzip 581 B 581 B ✓
index-HASH.js gzip 260 B 259 B ✓
link-HASH.js gzip 2.52 kB 2.52 kB ✓
routerDirect..HASH.js gzip 316 B 318 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 313 B 314 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.99 kB 7.98 kB ✅ -10 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 274 kB 273 kB ✓
Total 400 kB 399 kB ✅ -630 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 615 B ✓
middleware-r..fest.js gzip 156 B 156 B ✓
middleware.js gzip 43.9 kB 44.3 kB 🔴 +439 B (+1%)
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.5 kB 45.9 kB ⚠️ +437 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 722 B 719 B ✓
Total 722 B 719 B ✅ -3 B
Build Cache
Canary PR Change
0.pack gzip 4.39 MB 4.39 MB 🟢 5.6 kB (0%)
index.pack gzip 113 kB 115 kB 🔴 +1.8 kB (+2%)
index.pack.old gzip 113 kB 114 kB ✓
Total 4.62 MB 4.62 MB ✅ -3.58 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 348 kB 348 kB ✓
app-page-exp..prod.js gzip 193 kB 193 kB ✓
app-page-tur...dev.js gzip 347 kB 347 kB ✓
app-page-tur..prod.js gzip 193 kB 193 kB ✓
app-page-tur...dev.js gzip 344 kB 344 kB ✓
app-page-tur..prod.js gzip 191 kB 191 kB ✓
app-page.run...dev.js gzip 344 kB 344 kB ✓
app-page.run..prod.js gzip 191 kB 191 kB ✓
app-route-ex...dev.js gzip 77.3 kB 77.3 kB ✓
app-route-ex..prod.js gzip 52.7 kB 52.7 kB ✓
app-route-tu...dev.js gzip 77.3 kB 77.3 kB ✓
app-route-tu..prod.js gzip 52.8 kB 52.8 kB ✓
app-route-tu...dev.js gzip 76.9 kB 76.9 kB ✓
app-route-tu..prod.js gzip 52.5 kB 52.5 kB ✓
app-route.ru...dev.js gzip 76.9 kB 76.9 kB ✓
app-route.ru..prod.js gzip 52.5 kB 52.5 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 44.2 kB 44.2 kB ✓
pages-api-tu..prod.js gzip 33.6 kB 33.6 kB ✓
pages-api.ru...dev.js gzip 44.2 kB 44.2 kB ✓
pages-api.ru..prod.js gzip 33.6 kB 33.6 kB ✓
pages-turbo....dev.js gzip 53.5 kB 53.5 kB ✓
pages-turbo...prod.js gzip 39.3 kB 39.3 kB ✓
pages.runtim...dev.js gzip 53.5 kB 53.5 kB ✓
pages.runtim..prod.js gzip 39.3 kB 39.3 kB ✓
server.runti..prod.js gzip 63.1 kB 63.1 kB ✓
Total 3.07 MB 3.07 MB ⚠️ +3 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/d58a4108e1487c723d65f1d73bfaad7df46e4a38/next

Commit: d58a410

@github-actions github-actions Bot added the locked label May 9, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lukesandberg