fix: should only update cache when actually start new request #1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1e32f6b:
|
shuding
reviewed
May 20, 2022
Member
shuding
left a comment
shuding
left a comment
There was a problem hiding this comment.
Good catch! We will need a test for this
huozhi
reviewed
May 24, 2022
Member
huozhi
left a comment
huozhi
left a comment
There was a problem hiding this comment.
Can we separate the bug fix with e2e testing setup in 2 PRs? feel like they're not strongly bound together.
We also need to include need to include the test/e2e folder to prettier included files
shuding
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1974
https://codesandbox.io/s/loading-nh4jtc