Skip to content

Skip OIDC call in fetchRunKey when token already available #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TooTallNate merged 3 commits into from
Mar 13, 2026
Merged

Skip OIDC call in fetchRunKey when token already available #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
170f639
Skip OIDC call in fetchRunKey when token already available
TooTallNate Mar 12, 2026
4657b22
Add changeset for OIDC skip fix
TooTallNate Mar 13, 2026
ea276b3
Update changeset and comments to document token precedence order
TooTallNate Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fair-owls-tap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@workflow/world-vercel": patch
---

Reorder token resolution in `fetchRunKey` and `resolveLatestDeploymentId` to prefer `options.token` / `VERCEL_TOKEN` before calling OIDC, skipping the OIDC network call when a token is already available
12 changes: 8 additions & 4 deletions packages/world-vercel/src/encryption.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,14 @@ export async function fetchRunKey(
teamId?: string;
}
): Promise<Uint8Array | undefined> {
// Authenticate via provided token (CLI/config), OIDC token (runtime),
// or VERCEL_TOKEN env var (external tooling)
const oidcToken = await getVercelOidcToken().catch(() => null);
const token = options?.token ?? oidcToken ?? process.env.VERCEL_TOKEN;
// Authenticate via provided token (CLI/config), VERCEL_TOKEN env var
// (external tooling), or OIDC token (runtime) — in that order.
// OIDC is last to avoid an unnecessary network call when a token is
// already available (e.g. CLI or CI contexts).
const token =
options?.token ??
process.env.VERCEL_TOKEN ??
(await getVercelOidcToken().catch(() => null));
if (!token) {
Comment thread
TooTallNate marked this conversation as resolved.
throw new Error(
'Cannot fetch run key: no OIDC token or VERCEL_TOKEN available'
Expand Down
12 changes: 8 additions & 4 deletions packages/world-vercel/src/resolve-latest-deployment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,14 @@ export function createResolveLatestDeploymentId(
);
}

// Authenticate via provided token (CLI/config), OIDC token (runtime),
// or VERCEL_TOKEN env var (external tooling)
const oidcToken = await getVercelOidcToken().catch(() => null);
const token = config?.token ?? oidcToken ?? process.env.VERCEL_TOKEN;
// Authenticate via provided token (CLI/config), VERCEL_TOKEN env var
// (external tooling), or OIDC token (runtime) — in that order.
// OIDC is last to avoid an unnecessary network call when a token is
// already available (e.g. CLI or CI contexts).
const token =
config?.token ??
process.env.VERCEL_TOKEN ??
(await getVercelOidcToken().catch(() => null));
Comment thread
TooTallNate marked this conversation as resolved.
if (!token) {
throw new Error(
'Cannot resolve latest deployment: no OIDC token or VERCEL_TOKEN available'
Expand Down
Loading