You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The initial idea was that consuming web apps would add their own error boundaries around the web-shared package, but that ended up not being granular enough. For now, this isolates one of the main UI parts that could error individually and adds an ErrorBoundary.
Later, I'm planning to allow consumers of the web-shared package to define their own styling/components and pass them in, so that we don't have to pollute parent design by having local versions of error boundaries, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial idea was that consuming web apps would add their own error boundaries around the web-shared package, but that ended up not being granular enough. For now, this isolates one of the main UI parts that could error individually and adds an ErrorBoundary.
Later, I'm planning to allow consumers of the web-shared package to define their own styling/components and pass them in, so that we don't have to pollute parent design by having local versions of error boundaries, etc.