Skip to content

fix: esbuild md loader#766

Closed
gdaybrice wants to merge 1 commit intovercel:mainfrom
gdaybrice:fix/esbuild-md-loader
Closed

fix: esbuild md loader#766
gdaybrice wants to merge 1 commit intovercel:mainfrom
gdaybrice:fix/esbuild-md-loader

Conversation

@gdaybrice
Copy link
Copy Markdown
Contributor

Fixing #724

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 11, 2026

🦋 Changeset detected

Latest commit: a767ea2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@workflow/builders Patch
@workflow/next Patch
@workflow/astro Patch
@workflow/cli Patch
@workflow/nest Patch
@workflow/nitro Patch
@workflow/sveltekit Patch
@workflow/docs-typecheck Patch
workflow Patch
@workflow/world-testing Patch
@workflow/example-nest Patch
@workflow/nuxt Patch
@workflow/ai Patch
@workflow/core Patch
@workflow/web-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jan 11, 2026

@gdaybrice is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@gdaybrice gdaybrice force-pushed the fix/esbuild-md-loader branch from db0523d to 998213c Compare January 11, 2026 23:34
Comment thread packages/builders/src/base-builder.ts Outdated
@pranaygp
Copy link
Copy Markdown
Contributor

supporting markdown loading "by default" seems odd to me. Maybe the better option is to allow people to provide their own loaders. wdyt @ijjk ?

@gdaybrice
Copy link
Copy Markdown
Contributor Author

@pranaygp agree it's not ideal, would be better to support the turbopack configuration if any custom loader is setup.

@gdaybrice gdaybrice force-pushed the fix/esbuild-md-loader branch from 998213c to 5e878e5 Compare January 20, 2026 07:49
@gdaybrice
Copy link
Copy Markdown
Contributor Author

@pranaygp made some changes, is this a simpler approach?

Comment thread packages/builders/src/base-builder.ts
@gdaybrice gdaybrice force-pushed the fix/esbuild-md-loader branch from 5e878e5 to 631badb Compare January 20, 2026 08:15
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Jan 20, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​raw-loader@​4.0.2991009975100

View full report

Signed-off-by: Brice Lechatellier <brice@lechatellier.com>

# Conflicts:
#	pnpm-lock.yaml
@gdaybrice gdaybrice force-pushed the fix/esbuild-md-loader branch from cabee5e to a767ea2 Compare January 27, 2026 22:49
@gdaybrice
Copy link
Copy Markdown
Contributor Author

@pranaygp @ijjk can this be reviewed please? it's been blocking me for a while, happy to make changes if you don't like the approach.

Copy link
Copy Markdown
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi sorry for the delay here, any chance you could try upgrading to latest workflow package and Next.js v16.2.0-canary.48 and then enabling this flag in workflows

export default withWorkflow(nextConfig, { workflows: { lazyDiscovery: true } });

That will no longer use esbuild for bundling steps and discovery workflows/steps so the loader customizing should no longer be necessary separate of Next.js' config.

@gdaybrice gdaybrice closed this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants