Fix getImportPath package handling

.changeset/blue-mice-behave.md

@@ -0,0 +1,5 @@
+---
+"@workflow/builders": patch
+---
+
+Fix getImportPath package handling

packages/builders/src/module-specifier.test.ts

@@ -0,0 +1,211 @@
+import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { dirname, join } from 'node:path';
+import { afterEach, beforeEach, describe, expect, it } from 'vitest';
+import {
+  clearModuleSpecifierCache,
+  getImportPath,
+} from './module-specifier.js';
+
+function writeJson(path: string, value: unknown): void {
+  mkdirSync(dirname(path), { recursive: true });
+  writeFileSync(path, JSON.stringify(value, null, 2), 'utf-8');
+}
+
+function writeFile(path: string, contents = ''): void {
+  mkdirSync(dirname(path), { recursive: true });
+  writeFileSync(path, contents, 'utf-8');
+}
+
+describe('getImportPath', () => {
+  let testRoot: string;
+
+  beforeEach(() => {
+    clearModuleSpecifierCache();
+    testRoot = mkdtempSync(join(tmpdir(), 'workflow-module-specifier-'));
+  });
+
+  afterEach(() => {
+    clearModuleSpecifierCache();
+    rmSync(testRoot, { recursive: true, force: true });
+  });
+
+  it('uses package subpath import when file matches an export subpath', () => {
+    const projectRoot = join(testRoot, 'apps/chat');
+    const workspacePkgDir = join(testRoot, 'packages/agent');
+    const filePath = join(workspacePkgDir, 'src/server.ts');
+
+    writeJson(join(projectRoot, 'package.json'), {
+      name: 'chat',
+      dependencies: { '@internal/agent': 'workspace:*' },
+    });
+
+    writeJson(join(workspacePkgDir, 'package.json'), {
+      name: '@internal/agent',
+      version: '1.0.0',
+      exports: {
+        './server': './src/server.ts',
+      },
+    });
+
+    writeFile(filePath, `'use step';\n`);
+
+    expect(getImportPath(filePath, projectRoot)).toEqual({
+      importPath: '@internal/agent/server',
+      isPackage: true,
+    });
+  });
+
+  it('falls back to relative import when package has no root export', () => {
+    const projectRoot = join(testRoot, 'apps/chat');
+    const workspacePkgDir = join(testRoot, 'packages/agent');
+    const filePath = join(workspacePkgDir, 'src/server.ts');
+
+    writeJson(join(projectRoot, 'package.json'), {
+      name: 'chat',
+      dependencies: { '@internal/agent': 'workspace:*' },
+    });
+
+    writeJson(join(workspacePkgDir, 'package.json'), {
+      name: '@internal/agent',
+      version: '1.0.0',
+      exports: {
+        './server': './dist/server.js',
+      },
+    });
+
+    writeFile(filePath, `'use step';\n`);
+
+    expect(getImportPath(filePath, projectRoot)).toEqual({
+      importPath: '../../packages/agent/src/server.ts',
+      isPackage: false,
+    });
+  });
+
+  it('uses package root import for root exports', () => {
+    const projectRoot = join(testRoot, 'apps/chat');
+    const workspacePkgDir = join(testRoot, 'packages/agent');
+    const filePath = join(workspacePkgDir, 'src/index.ts');
+
+    writeJson(join(projectRoot, 'package.json'), {
+      name: 'chat',
+      dependencies: { '@internal/agent': 'workspace:*' },
+    });
+
+    writeJson(join(workspacePkgDir, 'package.json'), {
+      name: '@internal/agent',
+      version: '1.0.0',
+      exports: {
+        '.': './src/index.ts',
+      },
+    });
+
+    writeFile(filePath, `'use workflow';\n`);
+
+    expect(getImportPath(filePath, projectRoot)).toEqual({
+      importPath: '@internal/agent',
+      isPackage: true,
+    });
+  });
+
+  it('uses package root import when package module points to file', () => {
+    const projectRoot = join(testRoot, 'apps/chat');
+    const workspacePkgDir = join(testRoot, 'packages/agent');
+    const filePath = join(workspacePkgDir, 'src/index.mjs');
+
+    writeJson(join(projectRoot, 'package.json'), {
+      name: 'chat',
+      dependencies: { '@internal/agent': 'workspace:*' },
+    });
+
+    writeJson(join(workspacePkgDir, 'package.json'), {
+      name: '@internal/agent',
+      version: '1.0.0',
+      module: './src/index.mjs',
+      main: './dist/index.cjs',
+    });
+
+    writeFile(filePath, `'use workflow';\n`);
+
+    expect(getImportPath(filePath, projectRoot)).toEqual({
+      importPath: '@internal/agent',
+      isPackage: true,
+    });
+  });
+
+  it('uses package root import for conditional root exports', () => {
+    const projectRoot = join(testRoot, 'apps/chat');
+    const workspacePkgDir = join(testRoot, 'packages/agent');
+    const filePath = join(workspacePkgDir, 'src/index.js');
+
+    writeJson(join(projectRoot, 'package.json'), {
+      name: 'chat',
+      dependencies: { '@internal/agent': 'workspace:*' },
+    });
+
+    writeJson(join(workspacePkgDir, 'package.json'), {
+      name: '@internal/agent',
+      version: '1.0.0',
+      exports: {
+        '.': {
+          import: './src/index.mjs',
+          default: './src/index.js',
+        },
+      },
+    });
+
+    writeFile(filePath, `'use workflow';\n`);
+
+    expect(getImportPath(filePath, projectRoot)).toEqual({
+      importPath: '@internal/agent',
+      isPackage: true,
+    });
+  });
+
+  it('falls back to relative import for deep files in packages without exports', () => {
+    const projectRoot = join(testRoot, 'apps/chat');
+    const workspacePkgDir = join(testRoot, 'packages/agent');
+    const filePath = join(workspacePkgDir, 'lib/tools/dynamic/workflow.ts');
+
+    writeJson(join(projectRoot, 'package.json'), {
+      name: 'chat',
+      dependencies: { '@internal/agent': 'workspace:*' },
+    });
+
+    writeJson(join(workspacePkgDir, 'package.json'), {
+      name: '@internal/agent',
+      version: '1.0.0',
+    });
+
+    writeFile(filePath, `'use workflow';\n`);
+
+    expect(getImportPath(filePath, projectRoot)).toEqual({
+      importPath: '../../packages/agent/lib/tools/dynamic/workflow.ts',
+      isPackage: false,
+    });
+  });
+
+  it('uses package root import when package main points to file', () => {
+    const projectRoot = join(testRoot, 'apps/chat');
+    const workspacePkgDir = join(testRoot, 'packages/agent');
+    const filePath = join(workspacePkgDir, 'src/index.ts');
+
+    writeJson(join(projectRoot, 'package.json'), {
+      name: 'chat',
+      dependencies: { '@internal/agent': 'workspace:*' },
+    });
+
+    writeJson(join(workspacePkgDir, 'package.json'), {
+      name: '@internal/agent',
+      version: '1.0.0',
+      main: './src/index.ts',
+    });
+
+    writeFile(filePath, `'use step';\n`);
+
+    expect(getImportPath(filePath, projectRoot)).toEqual({
+      importPath: '@internal/agent',
+      isPackage: true,
+    });
+  });
+});