[e2e] Remove /api/hook and /api/test-health-check endpoints, call APIs directly#974
Conversation
🦋 Changeset detectedLatest commit: e0276c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (159 failed)mongodb (39 failed):
redis (39 failed):
starter (41 failed):
turso (40 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
/api/hook and /api/test-health-check endpoints, call APIs directly
There was a problem hiding this comment.
Pull request overview
This PR continues the E2E refactor from #958 by removing the remaining workbench HTTP indirection for hooks and queue-based health checks, updating E2E tests/benchmarks to call the runtime APIs directly, and adding the missing changeset for a Nitro prod manifest/handler fix.
Changes:
- Removed
/api/hookand/api/test-health-checkendpoints across workbench apps. - Refactored E2E hook + queue-health-check tests to use
getHookByToken()/resumeHook()/healthCheck()directly. - Simplified benchmark runner by removing debug logging and using
run.returnValuedirectly.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| workbench/vite/routes/api/test-health-check.post.ts | Removed queue-health-check test endpoint. |
| workbench/vite/routes/api/hook.post.ts | Removed hook resume endpoint. |
| workbench/sveltekit/src/routes/api/test-health-check/+server.ts | Removed queue-health-check test endpoint. |
| workbench/sveltekit/src/routes/api/hook/+server.ts | Removed hook resume endpoint. |
| workbench/nuxt/server/api/test-health-check.post.ts | Removed queue-health-check test endpoint. |
| workbench/nuxt/server/api/hook.post.ts | Removed hook resume endpoint. |
| workbench/nitro-v3/routes/api/test-health-check.post.ts | Removed queue-health-check test endpoint. |
| workbench/nitro-v3/routes/api/hook.post.ts | Removed hook resume endpoint. |
| workbench/nitro-v2/server/api/test-health-check.post.ts | Removed queue-health-check test endpoint. |
| workbench/nitro-v2/server/api/hook.post.ts | Removed hook resume endpoint. |
| workbench/nextjs-webpack/app/api/test-health-check/route.ts | Removed queue-health-check test endpoint. |
| workbench/nextjs-webpack/app/api/hook/route.ts | Removed hook resume endpoint. |
| workbench/nextjs-turbopack/app/api/test-health-check/route.ts | Removed queue-health-check test endpoint. |
| workbench/nextjs-turbopack/app/api/hook/route.ts | Removed hook resume endpoint route reference. |
| workbench/nest/src/app.controller.ts | Removed hook + queue-health-check endpoints from Nest controller. |
| workbench/hono/src/index.ts | Removed hook + queue-health-check routes from Hono app. |
| workbench/fastify/src/index.ts | Removed hook + queue-health-check routes from Fastify app. |
| workbench/express/src/index.ts | Removed hook + queue-health-check routes from Express app. |
| workbench/example/api/test-health-check.ts | Removed queue-health-check test endpoint. |
| workbench/example/api/hook.ts | Removed hook resume endpoint. |
| workbench/astro/src/pages/api/test-health-check.ts | Removed queue-health-check test endpoint. |
| workbench/astro/src/pages/api/hook.ts | Removed hook resume endpoint. |
| packages/core/e2e/e2e.test.ts | Updated hook + queue-health-check E2E tests to call runtime APIs directly. |
| packages/core/e2e/bench.bench.ts | Removed debug logging and awaitReturnValue() wrapper; use run.returnValue directly. |
| .changeset/expose-public-manifest.md | Adds patch changeset for Nitro prod manifest/handler fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… APIs directly - Remove debug logging from bench.bench.ts - Remove awaitReturnValue() wrapper, use run.returnValue directly in benchmarks - Add changeset for Nitro builder manifest fix - Refactor hookWorkflow tests to call getHookByToken()/resumeHook() directly (pass hook object to resumeHook to avoid duplicate lookups) - Refactor queue-based health check test to call healthCheck() directly - Assert specific error message for invalid hook token test - Remove /api/hook and /api/test-health-check endpoints from all workbench apps (nextjs-turbopack, nextjs-webpack, vite, hono, express, fastify, sveltekit, astro, nuxt, nitro-v2, nitro-v3, nest, example)
fc9c304 to
e0276c4
Compare

Follow-up to #958 that removes even more workbench app duplication / indirection:
bench.bench.tsawaitReturnValue()wrapper, userun.returnValuedirectly in benchmarkshookWorkflowtests to callgetHookByToken()/resumeHook()directlyhealthCheck()directly/api/hookand/api/test-health-checkendpoints from all workbench apps(nextjs-turbopack, nextjs-webpack, vite, hono, express, fastify, sveltekit,
astro, nuxt, nitro-v2, nitro-v3, nest, example)