Fix anonymous class expression names for serialization classes#991
Merged
TooTallNate merged 2 commits intomainfrom Feb 11, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 8d57648 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (41 failed)turso (41 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
When upstream bundlers like tsup/esbuild transform class declarations into anonymous class expressions (e.g. `var Foo = class { ... }`), the SWC plugin now re-inserts the binding name into the class expression (e.g. `var Foo = class Foo { ... }`). This preserves the class `.name` property through subsequent bundling passes, preventing runtime failures in downstream bundlers like Nitro's Rollup bundler that rely on the class expression name for serialization class registration.
ijjk
approved these changes
Feb 11, 2026
TooTallNate
force-pushed
the
02-10-fix_anonymous_class_expression_names_for_serialization_classes
branch
from
bf954f2 to
ae4f598
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the @workflow/swc-plugin transform to preserve class names for serializable classes when upstream bundlers convert named class declarations into anonymous class expressions, preventing downstream bundlers from losing the class identifier during subsequent bundling passes.
Changes:
- Update the SWC transform to re-insert the variable binding name into anonymous
classexpressions when custom serialization methods are present. - Update transform fixture outputs to reflect the newly named class expressions.
- Document the behavior in
spec.mdand publish a patch changeset.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/swc-plugin-workflow/transform/src/lib.rs | Implements binding-name re-insertion for anonymous serializable class expressions. |
| packages/swc-plugin-workflow/transform/tests/fixture/class-expression-binding-name/output-workflow.js | Updates expected workflow-mode fixture output to include class Shell. |
| packages/swc-plugin-workflow/transform/tests/fixture/class-expression-binding-name/output-step.js | Updates expected step-mode fixture output to include class Shell. |
| packages/swc-plugin-workflow/transform/tests/fixture/class-expression-binding-name/output-client.js | Updates expected client-mode fixture output to include class Shell. |
| packages/swc-plugin-workflow/spec.md | Documents the anonymous class expression name re-insertion behavior. |
| .changeset/happy-doodles-return.md | Adds a patch changeset for the plugin release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pranaygp
approved these changes
Feb 11, 2026
Contributor
pranaygp
left a comment
pranaygp
left a comment
There was a problem hiding this comment.
Looks good. Clean, well-scoped fix.
The guard conditions (has_serde && class_expr.ident.is_none()) correctly ensure this only fires for anonymous serialization classes, leaving named class expressions (like class _Bash) untouched. Test fixtures and spec updated appropriately.
…recompute internal_class_name after ident insertion
TooTallNate
deleted the
02-10-fix_anonymous_class_expression_names_for_serialization_classes
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upstream bundlers like tsup/esbuild transform class declarations into anonymous class expressions (e.g.
var Foo = class { ... }), the SWC plugin now re-inserts the binding name into the class expression (e.g.var Foo = class Foo { ... }). This preserves the class.nameproperty through subsequent bundling passes, preventing runtime failures in downstream bundlers like Nitro's Rollup bundler that rely on the class expression name for serialization class registration.