fix(tsconfig): target ES2017 to resolve TS2550 “Array.includes” error (#1)#2
Open
syntaxsurge wants to merge 1 commit intoverida:mainfrom
Open
fix(tsconfig): target ES2017 to resolve TS2550 “Array.includes” error (#1)#2syntaxsurge wants to merge 1 commit intoverida:mainfrom
syntaxsurge wants to merge 1 commit intoverida:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
❌ Problem
Running yarn start (or tsc --watch) threw
TS2550: Property 'includes' does not exist on type 'string[]'because the project was compiled against the default ES5 lib set, which doesn’t contain Array.prototype.includes().
✅ Solution
• Bumped compilerOptions.target from ES5 → ES2017 in tsconfig.json.
• ES2017 brings in the lib definitions for Array#includes, Object.entries, async/await, etc.
• No runtime polyfills required because the example already targets modern browsers/Node ≥ 8.
🔬 Verification
• yarn build and yarn start now complete without type-errors.
📌 Notes
• Kept all other tsconfig options intact.
• No JavaScript output changes—only TypeScript typings.
• This is the minimal fix; if we ever need newer language features we can move to ES2020+.