Skip to content

Conversation

@vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Dec 19, 2024

Vendor the fixes from CPython for GHSA-7pwv-g7hj-39pr and applies them at import time of synapse.common.

python/cpython#123067
python/cpython#123075

@vEpiphyte vEpiphyte added the bug label Dec 19, 2024
@vEpiphyte vEpiphyte added this to the v2.193.0 milestone Dec 19, 2024
@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 75.60976% with 10 lines in your changes missing coverage. Please review.

Project coverage is 96.37%. Comparing base (6694736) to head (d2af0cf).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
synapse/vendor/cpython/lib/http/cookies.py 30.76% 9 Missing ⚠️
synapse/common.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4045      +/-   ##
==========================================
- Coverage   96.47%   96.37%   -0.10%     
==========================================
  Files         254      256       +2     
  Lines       59604    59645      +41     
==========================================
- Hits        57500    57485      -15     
- Misses       2104     2160      +56     
Flag Coverage Δ
linux 96.37% <75.60%> (-0.03%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vEpiphyte vEpiphyte merged commit 746605b into master Dec 31, 2024
4 of 5 checks passed
@vEpiphyte vEpiphyte deleted the feat_cpython_httpcookies_vendor branch January 16, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants