This repository was archived by the owner on Feb 24, 2026. It is now read-only.
Mitm manager factory#15
Merged
viacheslav-fomin-main merged 4 commits intoJun 8, 2017
Merged
Conversation
…ager based on attributes from channel
| * @return concrete instance of {@link MitmManager} | ||
| */ | ||
| MitmManager getInstance(Channel channel); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
here is how we can check tenant preferences: channel.attr(ProxyHttpFiltersAdapter.preferences).get().getTrustAllServers()
Collaborator
Author
There was a problem hiding this comment.
I do not really like exposing the whole channel here but there is no easy way to get all the attributes at once from the channel
| @@ -556,7 +556,7 @@ private void initializeConnectionFlow() { | |||
| serverConnection.HTTPCONNECTWithChainedProxy); | |||
Collaborator
Author
There was a problem hiding this comment.
Tenant related attributes are stored in client to proxy connection channel
mjallday
approved these changes
Jun 8, 2017
| .withPort(0) | ||
| .withProxyAuthenticator(this) | ||
| .withManInTheMiddle(new SelfSignedMitmManager()) | ||
| .withManInTheMiddle(new MitmManagerFactory() { |
There was a problem hiding this comment.
can we do SelfSignedMitmManagerFactory here?
Collaborator
Author
There was a problem hiding this comment.
sure, will fix, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to: https://github.com/verygoodsecurity/vault/pull/1380
Introduces mitm manager factory which can create a different mitm manager based on channel attributes.