Remote address in client connection channel

[viacheslav-fomin-main]

Littleproxy part for https://github.com/verygoodsecurity/vault/issues/1478

[viacheslav-fomin-main]

We will discuss the versioning mechanism when we all get together in one room

[viacheslav-fomin-main]

There are 2 channels: client to proxy channel and proxy to destination server channel.

The proxy to server channel is created from client to proxy channel and contains reference to it. This reference (to client to proxy channel) is passed to mitm manager factory from ProxyToServerConnection (when a connection to remote server is established). To select a proper mitm manager (with white listed hosts) we need to pass active server connection host to client to proxy channel so it is accessible from ConditionallyInsecureMitmManagerFactory

[mjallday]

do we need to remove this once the connection has completed? otherwise we're going to maintain a reference to these channels forever won't we?

[viacheslav-fomin-main]

@mjallday each time a connection is established a new ClientToProxyConnection class is created with its corresponding new channel here https://github.com/adamfisk/LittleProxy/blob/master/src/main/java/org/littleshoot/proxy/impl/DefaultHttpProxyServer.java#L514
https://github.com/adamfisk/LittleProxy/blob/master/src/main/java/org/littleshoot/proxy/impl/ProxyConnection.java#L591
Also I read a book about netty and there was nothing about cleaning up attributes in the channel, it was said that the attributes are a good way of sharing state between components that may use the same channel (as it is thread safe, it can determine if the channel was called from particular thread and if not put it in queue)

But let me clarify it further so I am 100 percent sure

[mjallday]

This looks reasonable but I want to know about the cleanup process here. I fear this will accumulate references to the channels and never release them.

[mjallday]

should this be named REMOTE_ADDRESS_ATTR_KEY?

[viacheslav-fomin-main]

@mjallday each time a connection is established a new ClientToProxyConnection class is created with its corresponding new channel here https://github.com/adamfisk/LittleProxy/blob/master/src/main/java/org/littleshoot/proxy/impl/DefaultHttpProxyServer.java#L514
https://github.com/adamfisk/LittleProxy/blob/master/src/main/java/org/littleshoot/proxy/impl/ProxyConnection.java#L591
Also I read a book about netty and there was nothing about cleaning up attributes in the channel, it was said that the attributes are a good way of sharing state between components that may use the same channel (as it is thread safe, it can determine if the channel was called from particular thread and if not put it in queue)

But let me clarify it further so I am 100 percent sure

[viacheslav-fomin-main]

@mjallday

1. a new ClientToProxyConnection is created for every connection: https://github.com/adamfisk/LittleProxy/blob/master/src/main/java/org/littleshoot/proxy/impl/DefaultHttpProxyServer.java#L514
2. a new channel is created for every ClientToProxyConnection Remote address in client connection channel #17
3. ClientToProxyConnection owns ProxyToServerConnection
4. ProxyToServerConnection owns remoteAddress

So this.clientConnection.channel.attr(REMOTE_ADDRESS_ATTR_KEY).set(remoteAddress); should not result in memory leak.