This repository was archived by the owner on Feb 24, 2026. It is now read-only.
Implements custom proxy error handler#18
Merged
mjallday merged 5 commits intoJun 21, 2017
Merged
Conversation
viacheslav-fomin-main
changed the title
mjallday
reviewed
Jun 20, 2017
mjallday
left a comment
mjallday
left a comment
There was a problem hiding this comment.
this looks good but it's breaking the interface so we need to bump the major version number.
| LOG.error("Caught an exception on ClientToProxyConnection", cause); | ||
| ExceptionHandler exHandler = proxyServer.getClientToProxyExHandler(); | ||
| if (exHandler != null) { | ||
| LOG.debug("Custom exception handler is used to process the cause"); |
There was a problem hiding this comment.
please log the handler so it's easier to debug e.g. LOG.debug("Custom exception handler '" + ex.toString() + "' invoked", cause);
Collaborator
Author
|
@mjallday addressed your comments |
mjallday
approved these changes
Jun 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/verygoodsecurity/vault/issues/1480
WITH THIS IMPLEMENTATION WE WILL BE ABLE TO HANDLE THESE TYPES OF ERRORS: https://rollbar.com/VeryGood/VGS-Vault/items/1076/occurrences/26139703957/
Pipeline consists of handlers, in our case they are
ClientToProxyConnectionandProxyToServerConnectionand a handler can overrideexceptionCaughtmethod which handles an error that is thrown somewhere during processing.The error will be passed down the pipeline until it finds a handler that overrides the method. So I intervened with custom handler that will handle the error from within the
exceptionCaughtmethod.