Skip to content

Fix potentially very large loop when looking for rescue graph #4885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xchang1 merged 1 commit into from
Apr 27, 2026
Merged

Fix potentially very large loop when looking for rescue graph #4885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/snarl_distance_index.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1654,7 +1654,8 @@ cerr << "Start search along parent chain " << distance_index.net_handle_as_strin
super_graph->follow_edges(current_loop_handle, false, [&](const handle_t& next_handle) {
//If the next node is close enough and isn't exiting the snarl, then add it to stack
size_t new_distance = SnarlDistanceIndex::sum(current_loop_distance, super_graph->get_length(next_handle));
if (new_distance < min_distance && next_handle != start_out && next_handle != end_out) {
if (new_distance < min_distance && next_handle != start_out && next_handle != end_out &&
seen_nodes.count(std::make_pair(super_graph->get_id(next_handle), super_graph->get_is_reverse(next_handle))) == 0) {
loop_handles_to_check.emplace_back(next_handle, new_distance);
}
});
Expand Down Expand Up @@ -1882,7 +1883,8 @@ void subgraph_in_distance_range_walk_across_chain (const SnarlDistanceIndex& dis
super_graph->follow_edges(current_loop_handle, false, [&](const handle_t& next_handle) {
//If the next node is close enough and isn't exiting the snarl, then add it to stack
size_t new_distance = SnarlDistanceIndex::sum(current_loop_distance, super_graph->get_length(next_handle));
if (new_distance < min_distance && next_handle != start_out && next_handle != end_out) {
if (new_distance < min_distance && next_handle != start_out && next_handle != end_out &&
seen_nodes.count(std::make_pair(super_graph->get_id(next_handle), super_graph->get_is_reverse(next_handle))) == 0) {
loop_handles_to_check.emplace_back(next_handle, new_distance);
}
});
Expand Down
Loading