Make vg giraffe error when the minimizers or zipcodes are older than the distance index#4886
Open
Make vg giraffe error when the minimizers or zipcodes are older than the distance index#4886
vg giraffe error when the minimizers or zipcodes are older than the distance index#4886Conversation
Member
Author
|
We probably should extend/replace this with hashing the distance index and hiding the hash in the minimizer/zipcode file tags, like we do for the "graph name". |
…our generated headers
…e saving the min/zipcodes files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg giraffewill now stop with an error when the minimizers or zipcodes are older than the distance index they were supposedly generated from.Description
We wasted some time trying to map reads with the wrong distance index, which didn't go with the minimizers and zipcodes files, because it had been replaced later.
This adds an error to Giraffe in that case. We might want to demote it to a warning if we run into a lot of trouble with downloading these files from places in the wrong order and not preserving their modification times, inside of workflows.