remove unnecessary return info#4889
Open
faithokamoto wants to merge 1 commit intomasterfrom
Open
Conversation
Contributor
Author
|
Mac failed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
align_sequence_between()Description
I saw a TODO and thought I could tackle it for kicks. Indeed, while
align_sequence_between()/align_sequence_between_consistently()used to return a pair of values, the only thing we actually ever used those return values for was checking whether the first was nonzero or not. So now I simply have it return whether that first value would have been zero. Makes it easier to interpret. Also possibly saves a negligible amount of overhead that would have been spent constructing the pair.