[RSDK-10493] Update sdk version to something recent#10
[RSDK-10493] Update sdk version to something recent#10penguinland merged 6 commits intoviam-modules:mainfrom
Conversation
| go.viam.com/rdk v0.50.0 | ||
| go.viam.com/test v1.2.3 | ||
| go.viam.com/utils v0.1.113 | ||
| go.viam.com/rdk v0.70.0 |
There was a problem hiding this comment.
This is the only line in this file I changed manually. All the rest of the changes (including line 3) came from running go mod tidy. 🤷
bhaney
left a comment
There was a problem hiding this comment.
Change to jpeg and use the convenience function rather than decoding the image yourself
|
The size differences between jpeg and png can be gigantic- sometimes like 10x the size depending. Over grpc these image transfers slow our programs down considerably |
|
TIL, thanks! Take another look. I also updated the makefile so it rebuilds the module every time the source code changes. Without that, you need to delete the old module before |
bhaney
left a comment
There was a problem hiding this comment.
LGTM!
do click the "re-request review" button though in the future, as I have set up slack notifications to ping me when I have pending reviews to do
I went with 0.70.0, released last week. This week's release has already needed a patch (and may or may not need more patches).
Everything compiles and the tests pass, but I am unsure how to actually try running it outside of production. but I kinda imagine that if it compiles, it probably still works.
The
Camerainterface lost its streaming capability, so I changed to use.Image()to get frames instead. We often seem to use jpegs, which confuses me because it's a lossy format. So, I'm using PNGs. The interface looks like it ought to be format-agnostic, but that does seem like something we need to try out (perhaps in an RC before a "real" release).