[RSDK-9506] explicitly use xMin, yMin, etc. in bounding boxes#7
Merged
penguinland merged 12 commits intoviam-modules:mainfrom Jan 27, 2025
Merged
[RSDK-9506] explicitly use xMin, yMin, etc. in bounding boxes#7penguinland merged 12 commits intoviam-modules:mainfrom
penguinland merged 12 commits intoviam-modules:mainfrom
Conversation
penguinland
commented
Jan 9, 2025
bhaney
requested changes
Jan 13, 2025
| CountPeriod float64 `json:"sampling_period_s"` | ||
| NSamples int `json:"n_samples"` | ||
| ExtraFields map[string]interface{} `json:"extra_fields"` | ||
| ValidRegions map[string][]BoundingBoxConfig `json:"valid_regions"` |
Collaborator
There was a problem hiding this comment.
You'll def want to manually test this on a local machine to see if it works as intended
000b768 to
22a38fd
Compare
Contributor
Author
|
Take another look. I've added a bunch of unit tests, and they all pass. I've also gotten this up and working with a webcam on my desk: It reads "none" when I duck into the bottom half of the frame, and "one" when I sit up straight in the top half. I can change the Y range to the full 0-1 and the X range to 0-0.5, and it reads "one" when I'm in the left half and "none" when I'm in the right half. Finally, if I set XMax and XMin both to 0, it reads "one" no matter where in the frame I am (and "none" if I'm out of frame) |
penguinland
added a commit
to penguinland/queue-estimator
that referenced
this pull request
Jan 27, 2025
Merged
penguinland
added a commit
that referenced
this pull request
Jan 27, 2025
* update readme per PR #7 * tweak the text, too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything compiles, but I haven't tried running it yet. I'll do that while you take a look at the changes...
(doing this now because Alexis got confused why a ticket assigned to me was in her epic)