[APP-15050] Add APIs for device tokens and firebase configs#824
[APP-15050] Add APIs for device tokens and firebase configs#824martha-johnston merged 10 commits intomainfrom
Conversation
martha-johnston
force-pushed
the
martha/push-notifications
branch
from
bc4b65b to
6d714de
Compare
clintpurser
left a comment
clintpurser
left a comment
There was a problem hiding this comment.
overall LGTM - a few qs, one nit, and one minor thing i might prefer we change. but up to you because its not that serious.
| string config_json = 3; | ||
| } | ||
|
|
||
| message SetFirebaseConfigResponse {} |
There was a problem hiding this comment.
q - should this perhaps return the ID of the newly set firebase config?
There was a problem hiding this comment.
I think that's why we even added GetFirebaseConfigRequest, so you could see what bundle id was associated with your org
proto/viam/app/v1/app.proto
Outdated
| } | ||
|
|
||
| message GetFirebaseConfigResponse { | ||
| string bundle_id = 1; |
There was a problem hiding this comment.
q - is the app id enough here? is there some unique UUID we might want to return, or some other information?
maybe date set, and by which user? as well as the associated app id?
There was a problem hiding this comment.
i guess, bundle_id should already be unique. so relying on that as the unique identifier might just work.
There was a problem hiding this comment.
yeah I think the goal is just knowing what bundle id/app is associated with your org based on what we discussed in the scope
Co-authored-by: Clint Purser <clintpurser@gmail.com>
martha-johnston
added
ready-for-protos
martha-johnston
added
ready-for-protos
2 participants
https://viam.atlassian.net/browse/APP-15050
This PR adds
UploadDevicePushToken,DeleteDevicePushToken, andGetDevicePushTokensso each device token for every user can be stored and accessed in the mongo user collection. It also addsSetFirebaseConfig,GetFirebaseConfigandDeleteFirebaseConfig, so that an app owner can store their firebase config json in a new mongo firebase collection in order to sent push notifications to any app through Viam triggers