fix: morph/react pass data value to formatOut function#236
Merged
alex-vladut merged 1 commit intomasterfrom May 7, 2021
Merged
fix: morph/react pass data value to formatOut function#236alex-vladut merged 1 commit intomasterfrom
alex-vladut merged 1 commit intomasterfrom
Conversation
dariocravero
approved these changes
May 7, 2021
|
@CamilaSau asked the same a while back 😬. They used to be the same file but I found it made it harder to reason about what was actually the final content for them. I agree it's a problem though. I can think of two things:
|
Contributor
Author
|
I think we can explore that option, not sure exactly how that would look like. Do you mind maybe adding a GitHub issue for that to describe a bit the approach proposed here? |
|
done in #238 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found out I made the change in
Data.tools.jsbut didn't apply it toData.jstoo. Due to that, filtering the comms threads based on status worked fine locally, but when I tested it on staging I got an error. Do you have any strategy to test these changes locally to make sure the 2 files are in sync?