Skip to content

fix: morph/react pass data value to formatOut function#236

Merged
alex-vladut merged 1 commit intomasterfrom
fix-data-on-change
May 7, 2021
Merged

fix: morph/react pass data value to formatOut function#236
alex-vladut merged 1 commit intomasterfrom
fix-data-on-change

Conversation

@alex-vladut
Copy link
Contributor

I found out I made the change in Data.tools.js but didn't apply it to Data.js too. Due to that, filtering the comms threads based on status worked fine locally, but when I tested it on staging I got an error. Do you have any strategy to test these changes locally to make sure the 2 files are in sync?

@alex-vladut alex-vladut requested a review from dariocravero May 7, 2021 08:29
@alex-vladut alex-vladut merged commit 16e8ec0 into master May 7, 2021
@alex-vladut alex-vladut deleted the fix-data-on-change branch May 7, 2021 09:02
@dariocravero
Copy link

@CamilaSau asked the same a while back 😬. They used to be the same file but I found it made it harder to reason about what was actually the final content for them. I agree it's a problem though. I can think of two things:

  • a commit hook that asks if you only change one,
  • use markers in one file and treat it as a template where we strip thing out based off that marker
    What do you think?

@alex-vladut
Copy link
Contributor Author

I think we can explore that option, not sure exactly how that would look like. Do you mind maybe adding a GitHub issue for that to describe a bit the approach proposed here?

@dariocravero
Copy link

done in #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants