Add heredoc #120
Merged
Add heredoc #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattn
commented
Jul 19, 2019
tyru
requested changes
Jul 19, 2019
Member
Author
|
PTAL |
Member
|
🙌 |
Member
|
@mattn please tell me if it's available to review 🙆♂ |
Member
|
Current heredoc implementations may have more problems than we found. vim-jp/issues#1294 So we can skip heredoc support now, we should work on other issues. |
Member
|
@mattn this can be merged if you fix conflict 👍 |
tyru
approved these changes
Mar 6, 2020
Member
|
I forgot I have permission for this branch. fixed remaining vint errors. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.