Amend the current tag regex to match tags like my-tag#3
Open
AshinGau wants to merge 4 commits intovim-scripts:masterfrom
Open
Amend the current tag regex to match tags like my-tag#3AshinGau wants to merge 4 commits intovim-scripts:masterfrom
AshinGau wants to merge 4 commits intovim-scripts:masterfrom
Conversation
The getCurrentTag() function previously didn't account for tags with numbers in them such as h1, h2, etc. Also it didn't account for special characters such as # anywhere within < and >.
This was happening because the pattern would match 'a' for the div rather than 'div' since we grab the first occurrence of a tag in the line. http://stackoverflow.com/questions/11865845
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when type <my-tag>, it fails to close the tag because of the imperfect tag regex.