Add convenience methods to quaternion and matrix4 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
reviewed
Apr 24, 2025
Contributor
ibgreen
left a comment
ibgreen
left a comment
There was a problem hiding this comment.
@GuoBinyong Many thanks for the contributions very appreciated.
Even though it is some extra work for you, it might be best to split them into separate PR for quickest resolution.
- New public methods require documentation updates, and mention in
docs/whats-new.md - At least a simple test case for the new method is also required.
| * @param matrix3 | ||
| * @returns self | ||
| */ | ||
| fromMatrix3(matrix3: Readonly<NumericArray>): this { |
Contributor
There was a problem hiding this comment.
This is fine, though it does add a little to the size of the Matrix4 class for every user.
Contributor
There was a problem hiding this comment.
As you can see in the CI log, you need to run yarn lint fix
You are welcome to join our OpenJS slack channel, see https://openvisualization.org for the link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following facilitation methods have been added:
Matrix4#fromMatrix3()：Transitions from Matrix3 to Matrix4 are a common requirement, but there is currently no API for this, so this method has been addedQuaternion#fromEuler(euler: Euler)：