Skip to content

Minimal footer#2370

Closed
mshujamalik-ebi wants to merge 6 commits intodevelopfrom
minimal-footer
Closed

Minimal footer#2370
mshujamalik-ebi wants to merge 6 commits intodevelopfrom
minimal-footer

Conversation

@mshujamalik-ebi
Copy link
Copy Markdown
Collaborator

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026

Deploy Preview for tubular-strudel-7ad396 ready!

Name Link
🔨 Latest commit b8a6eff
🔍 Latest deploy log https://app.netlify.com/projects/tubular-strudel-7ad396/deploys/69efdaa0636c2900089ff9f7
😎 Deploy Preview https://deploy-preview-2370--tubular-strudel-7ad396.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sandykadam
Copy link
Copy Markdown
Collaborator

@mshujamalik-ebi on white varient links hover doesn't look correct, please check

}

.vf-u-background-color-ui--white .vf-footer__link:hover {
color: #000;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't hardcode colors, there are already classes of colors, use those variables
e.g --vf-ui-color--black

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@bhushan-ebi
Copy link
Copy Markdown
Collaborator

Hi @mshujamalik-ebi, please note the issues in this PR as per my current observation:

  1. The Readme.md doesn't have the correct content as per the footer content provided by Ux team here and as discussed earlier
  2. The page needs to look the way it's shown here as discussed.
  3. The code would just show 2 variants as per the .njk file you added. It needs to account for the different variants (as per design) which should each show a different HTML. You'll need to add these variants in .config.yml file and when each context is read in .njk file, it would render the particular version.
  4. I'd suggest to have dark and light variants rendered based on styling instead of having different HTML for them.

Regards,
Bhushan

@mshujamalik-ebi mshujamalik-ebi deleted the minimal-footer branch April 28, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants