Minimal modular footer#2372
Conversation
✅ Deploy Preview for tubular-strudel-7ad396 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| @@ -0,0 +1,40 @@ | |||
| ### 1.2.1 | |||
There was a problem hiding this comment.
@bhushan-ebi since this is new component it should have version starting from v1.0.0 right ?
There was a problem hiding this comment.
@sandykadam Since this is not a new component as we're updating the vf-footer and releasing the new version of same component, I'd say it should be one version above the current release of vf-footer.
| "name": "@visual-framework/vf-footer", | ||
| "description": "vf-footer component", | ||
| "homepage": "https://stable.visual-framework.dev/", | ||
| "author": "VF", | ||
| "license": "Apache 2.0", | ||
| "style": "build/vf-footer.css", | ||
| "main": "build/index.js", | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "repo": "https://github.com/visual-framework/vf-core/tree/master/components/elements/vf-footer", |
There was a problem hiding this comment.
vf-footer or vf-modular-footer ?
There was a problem hiding this comment.
Yes, as per our current discussion this will be vf-footer but let's connect on it tomorrow in office to finalise.
|
|
||
| // Keep spacing consistent across the three logical rows. | ||
| .vf-modular-footer { | ||
| border-top: 4px solid color(green); |
There was a problem hiding this comment.
use core color variables!!
| } | ||
|
|
||
| .vf-modular-footer__partners { | ||
| border-top: $vf-modular-footer-partner-rule-width solid color(green); |
| $vf-footer-link--color: ui-color(white); | ||
| $vf-footer-link--hover-color: color(grey--lightest); | ||
| $vf-footer-link--visited-color: color(grey--lightest); |
There was a problem hiding this comment.
all color variables available use them
| @@ -0,0 +1,3 @@ | |||
| ### 1.0.0-beta.1 | |||
There was a problem hiding this comment.
@mshujamalik-ebi sorry I think this should be 1.0.0-alpha.1. I know we discussed to use beta, but since this is first release, let's put it as alpha. Please update package.json as well.
|
@mshujamalik-ebi let's finalise whether to use vf-footer or this new component for modular-footer. Based on that this PR will change. Moreover the landing page content also needs to be shown and we'll decide how to show it on click of Footer link in mega menu. |
3 participants
No description provided.