Skip to content

Remove terms of use link from Banner component #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mshujamalik-ebi wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove terms of use link from Banner component #2374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/vf-banner/vf-banner--fixed.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ data-vf-js-banner-extra-button="<a href='#'>Optional button</a><a target='_blank
data-vf-js-banner-auto-accept="false">
<div class="vf-banner__content | vf-grid" data-vf-js-banner-text>
<p class="vf-banner__text vf-banner__text--lg">
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a> and <a class="vf-banner__link" href="JavaScript:Void(0);">Terms Of Use</a>.
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a>.
</p>
</div>
</div>
Expand All @@ -21,7 +21,7 @@ data-vf-js-banner-state="persistent"
data-vf-js-banner-extra-button="<a href='#'>Optional button</a><a target='_blank' href='#'>New tab button</a>">
<div class="vf-banner__content | vf-grid" data-vf-js-banner-notice-text>
<p class="vf-text vf-text-body--2">
A persistent banner <a class="vf-link" href="JavaScript:Void(0);">Privacy Notice</a> and <a class="vf-link" href="JavaScript:Void(0);">Terms Of Use</a>.
A persistent banner <a class="vf-link" href="JavaScript:Void(0);">Privacy Notice</a>.
</p>
</div>
</div> -->
Expand Down
2 changes: 1 addition & 1 deletion components/vf-banner/vf-banner.angular.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ declare function vfBanner(): any;
data-vf-js-banner-auto-accept="false">
<div class="vf-banner__content | vf-grid" data-vf-js-banner-text>
<p class="vf-banner__text vf-banner__text--lg">
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a> and <a class="vf-banner__link" href="JavaScript:Void(0);">Terms Of Use</a>.
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a>.
</p>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions components/vf-banner/vf-banner.angular/esm2020/lib/vf-banner.angular.component.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ VfBannerAngularComponent.ɵcmp = i0.ɵɵngDeclareComponent({ minVersion: "14.0.0
data-vf-js-banner-auto-accept="false">
<div class="vf-banner__content | vf-grid" data-vf-js-banner-text>
<p class="vf-banner__text vf-banner__text--lg">
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a> and <a class="vf-banner__link" href="JavaScript:Void(0);">Terms Of Use</a>.
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a>.
</p>
</div>
</div>
Expand Down Expand Up @@ -122,7 +122,7 @@ i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "15.2.10", ngImpo
data-vf-js-banner-auto-accept="false">
<div class="vf-banner__content | vf-grid" data-vf-js-banner-text>
<p class="vf-banner__text vf-banner__text--lg">
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a> and <a class="vf-banner__link" href="JavaScript:Void(0);">Terms Of Use</a>.
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a>.
</p>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions components/vf-banner/vf-banner.angular/fesm2015/vf-banner.angular.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ VfBannerAngularComponent.ɵcmp = i0.ɵɵngDeclareComponent({ minVersion: "14.0.0
data-vf-js-banner-auto-accept="false">
<div class="vf-banner__content | vf-grid" data-vf-js-banner-text>
<p class="vf-banner__text vf-banner__text--lg">
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a> and <a class="vf-banner__link" href="JavaScript:Void(0);">Terms Of Use</a>.
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a>.
</p>
</div>
</div>
Expand Down Expand Up @@ -124,7 +124,7 @@ i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "15.2.10", ngImpo
data-vf-js-banner-auto-accept="false">
<div class="vf-banner__content | vf-grid" data-vf-js-banner-text>
<p class="vf-banner__text vf-banner__text--lg">
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a> and <a class="vf-banner__link" href="JavaScript:Void(0);">Terms Of Use</a>.
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a>.
</p>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion components/vf-banner/vf-banner.angular/fesm2015/vf-banner.angular.mjs.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions components/vf-banner/vf-banner.angular/fesm2020/vf-banner.angular.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ VfBannerAngularComponent.ɵcmp = i0.ɵɵngDeclareComponent({ minVersion: "14.0.0
data-vf-js-banner-auto-accept="false">
<div class="vf-banner__content | vf-grid" data-vf-js-banner-text>
<p class="vf-banner__text vf-banner__text--lg">
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a> and <a class="vf-banner__link" href="JavaScript:Void(0);">Terms Of Use</a>.
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a>.
</p>
</div>
</div>
Expand Down Expand Up @@ -124,7 +124,7 @@ i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "15.2.10", ngImpo
data-vf-js-banner-auto-accept="false">
<div class="vf-banner__content | vf-grid" data-vf-js-banner-text>
<p class="vf-banner__text vf-banner__text--lg">
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a> and <a class="vf-banner__link" href="JavaScript:Void(0);">Terms Of Use</a>.
This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a class="vf-banner__link" href="JavaScript:Void(0);">Privacy Notice</a>.
</p>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion components/vf-banner/vf-banner.angular/fesm2020/vf-banner.angular.mjs.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion components/vf-banner/vf-banner.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function VfBanner({
);
case "fixed":
banner_msg =
"This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a className='vf-banner__link' href='JavaScript:Void(0);'>Privacy Notice</a> and <a className='vf-banner__link' href='JavaScript:Void(0);'>Terms Of Use</a>.";
"This website uses cookies, and the limiting processing of your personal data to function. By using the site you are agreeing to this as outlined in our <a className='vf-banner__link' href='JavaScript:Void(0);'>Privacy Notice</a>.";
return (
<div
className="vf-banner vf-banner--fixed vf-banner--bottom vf-banner--notice"
Expand Down
1 change: 0 additions & 1 deletion components/vf-banner/vf-banner.react.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ describe("VfBanner Component", () => {
test("renders fixed banner with privacy notice", () => {
render(<VfBanner banner__type="fixed" />);
expect(screen.getByText("Privacy Notice")).toBeInTheDocument();
expect(screen.getByText("Terms Of Use")).toBeInTheDocument();
});

test("renders top banner with survey link", () => {
Expand Down
Loading
Loading