Skip to content

Markers - New markers can override existing markers #142

@adrian-moisa

Description

@adrian-moisa

If the text selection perfectly matches a marker then the dropdown works fine. However if the selection does not overall the marker then no layers are displayed. This is probably happening because the rules for the other styles are different. If you select text that is partly bold partly regular, then the bold button is not highlighted. Meaning that when you click it you have the option to add bold. I believe this behaviour is rather logical and should not change.

Screen.Recording.2022-09-30.at.16.10.22.mov

New Markers override existing markers
Related to the same behaviour. If we select text that contains a marker inside then when we attempt to add a new marker, the old one or old ones get discarded and the new marker is added. This behaviour is unacceptable for VS. We can't simply lose metadata because the editor overrode the markers and therefore we lost the internal UUID that linked the markers to the metadata objects.

As you can see in this demo, we are not supposed to lose old markers.

Screen.Recording.2022-09-30.at.16.09.05.mov

Join on discord to get advice and help or follow us on YouTube Visual Coding to learn more about the architecture of Visual Editor and other Flutter apps.

Metadata

Metadata

Assignees

No one assigned

    Labels

    closedEither incomplete specs, irrelevant, or not going to do

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions