-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Links in table charts #2486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
f55f786 to
d4276a0
Compare
|
Nice, @bprusinowski 🎉 Maybe the field labelling is still a bit jargony for non-technical users. Could we consider something along the lines of "Link column" for Target dimension, "Link argument" for Source dimension? Also, I still like the links at the end of the rows (the initial behaviour) and think this could still be valuable for some users. We might want to consider keeping this functionality as an additional option in the dropdown. What do you think? cc @sosiology |
|
Thanks @adintegra! Yes, we should definitely tweak the labels and potentially some styles too 😄 I agree with another use case also being useful – we might bring it back pending feedback from tomorrow's sync? Or do you think it should be implemented upfront? Definitely there's value in this too, especially when the link is treated on a more "per-row" level, and not column level 👍 |
Closes #
This PR introduces links to table charts that can take a base URL and given dimension to dynamically construct a per-row, per-column link.
How to test