refactor: remove conditional disableDistinct and make it always enabled
#2509
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
The e2e test appears unrelated. Screenshot from Playwright: 
|
ludovicm67
approved these changes
Jan 21, 2026
ludovicm67
left a comment
ludovicm67
left a comment
There was a problem hiding this comment.
Looks ok ; the E2E issue doesn't seems to be introduced by your changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove
DISTINCTandGROUP BYfrom SPARQL generated byrdf-cube-view-query.The assumption is that DISTINCT was necessary for Stardog to prevent duplicate rows. It appears unnecessary or GraphDB