This repository was archived by the owner on Mar 19, 2026. It is now read-only.
fix: externalize optimizeDeps.exclude via rolldownCjsExternalPlugin (fix test-serve playground/external)#31
Merged
underfin merged 3 commits intoJul 29, 2024
Conversation
test-server playground/external)
test-server playground/external)optimizeDeps.exclude via rolldownCjsExternalPlugin (fix test-server playground/external)
optimizeDeps.exclude via rolldownCjsExternalPlugin (fix test-server playground/external)optimizeDeps.exclude via rolldownCjsExternalPlugin (fix test-serve playground/external)
Member
|
@hi-ogawa I upgrade the lastet rolldown look like the |
f35336e to
8267755
Compare
5edc81d to
da7294e
Compare
Author
|
I think |
Author
|
It looks like |
Member
|
Ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently
optimizeDeps.excludeis externalized at the config levelrolldown.rolldown({ external: ... })and it looks likerolldownCjsExternalPlugindoesn't have a chance to fixup cjs external. This manifests as test failures inplayground/external.Since
rolldownCjsExternalPluginalso handles non-cjs external, I simply removed rolldown'sexternalconfig and it looks like tests are passing.Only the last commit 5edc81d is the actual fix and first commits are the same one from #28.