Skip to content

fix: add jsx dev runtime to optimizeDeps#147

Merged
ArnaudBarre merged 1 commit intomainfrom
dev-runtime
Apr 17, 2023
Merged

fix: add jsx dev runtime to optimizeDeps#147
ArnaudBarre merged 1 commit intomainfrom
dev-runtime

Conversation

@ArnaudBarre
Copy link
Member

Rollback part of the change from #132 because it makes cold start slower for storybook. Two differences from what is actually published:

  • We don't force the default for esbuild. This allow TS only projects to handle multiple jsx runtime. It's very edge case, but doesn't cost anything to let it open because 'react' is also the default for esbuild.
  • We take into account the option for optimizeDeps so that works for other runtimes

@ArnaudBarre ArnaudBarre merged commit 3bbd8f0 into main Apr 17, 2023
@ArnaudBarre ArnaudBarre deleted the dev-runtime branch April 17, 2023 21:57
sapphi-red pushed a commit that referenced this pull request Mar 31, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants