Skip to content

fix: don't invalidate when code is invalid #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-dev merged 1 commit into from
Dec 19, 2022
Merged

fix: don't invalidate when code is invalid #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/plugin-react/src/fast-refresh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ function isReactRefreshBoundary(mod) {
}
import.meta.hot.accept(mod => {
if (!mod) return;
if (isReactRefreshBoundary(mod)) {
${timeout}
} else {
Expand Down
30 changes: 26 additions & 4 deletions playground/react/__tests__/react.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,34 @@ test('should update', async () => {
})

test('should hmr', async () => {
editFile('App.jsx', (code) => code.replace('Vite + React', 'Updated'))
await untilUpdated(() => page.textContent('h1'), 'Hello Updated')
editFile('App.jsx', (code) =>
code.replace('Vite + React', 'Vite + React Updated'),
)
await untilUpdated(() => page.textContent('h1'), 'Hello Vite + React Updated')
// preserve state
expect(await page.textContent('#state-button')).toMatch('count is: 1')

editFile('App.jsx', (code) =>
code.replace('Vite + React Updated', 'Vite + React'),
)
await untilUpdated(() => page.textContent('h1'), 'Hello Vite + React')
})

test.runIf(isServe)('should not invalidate when code is invalid', async () => {
editFile('App.jsx', (code) =>
code.replace('<div className="App">', '<div className="App"}>'),
)

await untilUpdated(
() => page.textContent('vite-error-overlay .message-body'),
'Unexpected token',
)
// if import.meta.invalidate happened, the old page won't be shown because the page is reloaded
expect(await page.textContent('h1')).toMatch('Hello Vite + React')

editFile('App.jsx', (code) =>
code.replace('<div className="App"}>', '<div className="App">'),
)
})

test.runIf(isServe)(
Expand Down Expand Up @@ -59,7 +83,6 @@ if (!isBuild) {
'[vite] hot updated: /hmr/parent.jsx',
'Parent rendered',
],
true,
)
await untilUpdated(() => page.textContent('#parent'), 'Updated')
})
Expand All @@ -86,7 +109,6 @@ if (!isBuild) {
'[vite] hot updated: /context/ContextButton.jsx',
'Parent rendered',
],
true,
)
await untilUpdated(
() => page.textContent('#context-provider'),
Expand Down