fix(esbuild): transpile with esnext in dev#10207
Merged
Conversation
patak-dev
approved these changes
Sep 23, 2022
Member
|
@bluwy would you also backport to the v3.1 branch? I think it would be good to fix it there too. |
This was referenced Sep 23, 2022
3 tasks
8 tasks
This was referenced Sep 29, 2022
antfu
pushed a commit
that referenced
this pull request
Oct 2, 2022
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #10167
In dev transpiling ts/tsx (etc) and vue (with
lang="ts"), set esbuild target toesnextto prevent syntax lowering. This should only affect dev, as build runs another round of transpile based onbuild.target.Additional context
Thanks @sapphi-red for digging into this.
Given that this used to work in the past, I think this isn't a breaking change.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).