fix(resolve): deep import resolvedId error#13010
Conversation
|
|
|
@bluwy leaving a reference of why we are adding the extension to the original I was never sure if this was the right approach though, and it has continued to bring issues. We could merge this PR as a temporal patch if it fixes the issue at hand but we need to review how we handle externalization in a holistic way in the next minor or Vite 5. Hopefully removing the need for the current double resolve we nee to know if it should externalize in SSR. |
patak-cat
left a comment
There was a problem hiding this comment.
I think this guard makes sense, at least as a temporal patch to the problem. There are cases where resolved.id doesn't start with id, so it is probable we may not remove this guard later on. Let's merge it so we can do a release but leave the issue open to track a long-term solution.
Description
temporal fix for #12997 (edited by @patak-dev)
rel #12461
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).