Skip to content

feat: import public non-asset URL#13422

Merged
patak-cat merged 2 commits into
vitejs:mainfrom
sapphi-red:feat/public-non-asset-url
Jun 9, 2023
Merged

feat: import public non-asset URL#13422
patak-cat merged 2 commits into
vitejs:mainfrom
sapphi-red:feat/public-non-asset-url

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red commented Jun 4, 2023

Description

Add support for import '/foo.json?url' (foo.json is in public directory) and improve errors for importing .json in public directory.

behavior after this PR behavior before this PR
import foo from '/public/foo.json' warning (foo is the content of foo.json) warning (foo is the content of foo.json)
import foo from '/public/foo.json?url' warning (foo is the URL of foo.json) warning (foo is the URL of foo.json)
import foo from '/foo.json' error error
import foo from '/foo.json?url' no error (foo is the URL of foo.json) error

close #13284

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy previously approved these changes Jun 9, 2023
patak-cat
patak-cat previously approved these changes Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Added "Turn off public JavaScript reference hints"

3 participants