fix(css): use single postcss instance#13738
Merged
patak-cat merged 1 commit intovitejs:mainfrom Jul 7, 2023
Merged
Conversation
|
|
Member
Author
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
compileCSSfunction calls PostCSS inside and #8400 usedcompileCSSfunction inside the post-css-import'sloadoption.This causes a different PostCSS instance to be used inside
@importand broke #13732. Also I guess running multiple PostCSS instances will hurt performance if tailwind is used since tailwind will crawl the files for every PostCSS instance.This PR extracts the preprocessor part of
compileCSSfunction tocompileCSSPreprocessorfunction and uses that function in the post-css-import'sloadoption. I found that #8400 didn't implement sourcemap support but I didn't implemented that because it would be complicated.close #13732
refs #8400
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).