fix(ssr): handle error from restart

[bluwy]

Description

fix #13735

The bug comes from this SvelteKit code, which runs ssrLoadModule immediately on reload request.

Additional context

It's hard to make the test error reliably, so added a very simple one for now. I noticed it may happen once in a while which we could catch.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[bluwy]

So my test actually caused a fail, and I did saw that error happening locally once in a while. I try to check again that later tonight, or otherwise remove the test for now.

[patak-cat]

Thanks for looking into this @bluwy! I have doubts if this is the best long-term solution. I'm afraid there could be some global state that gets corrupted because this error wasn't handled. With the browser we know there will be a hard reload but that isn't the case with ssrLoadModule. Should SvelteKit have a try/catch and ignore the error instead?

I think your solution is good for a change done in a minor though. So we better merge it and then we could review in Vite 5 if we should rework this.

[patak-cat]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
analogjs	✅ success
astro	✅ success
histoire	❌ failure
iles	❌ failure
ladle	✅ success
laravel	✅ success
marko	✅ success
nuxt	✅ success
nx	✅ success
previewjs	✅ success
qwik	✅ success
rakkas	✅ success
sveltekit	✅ success
unocss	✅ success
vite-plugin-pwa	✅ success
vite-plugin-ssr	✅ success
vite-plugin-react	✅ success
vite-plugin-react-pages	✅ success
vite-plugin-react-swc	✅ success
vite-plugin-svelte	✅ success
vite-plugin-vue	✅ success
vite-setup-catalogue	✅ success
vitepress	✅ success
vitest	✅ success

[bluwy]

Actually, yeah. I did this fix a bit too quick, it indeed seems like it would cause an incorrect state in SvelteKit side 🤔 Maybe we should fix it there instead.

I thought fixing this here first because the error we emit is sort-of internal and it's meant for us to catch and not corrupt the state/server. Which in the issue's case it exits the server. (EDIT: after further checking, the exist could be cause by the hack instead.)

[bluwy]

Discussed with patak that this isn't the right fix as it returns an incorrect state.