fix: code frame was not generated for postcss errors#14986
Merged
Conversation
patak-cat
previously approved these changes
Nov 14, 2023
bluwy
approved these changes
Nov 15, 2023
patak-cat
approved these changes
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Includes changes in #14984, please merge that one beforeCode frame was not generated for PostCSS errors. This PR fixes that and reverts #6293 as it's now handled inside the plugin.
Also this PR fixes a bug that the caret position was not correct for PostCSS errors/warnings. PostCSS uses 1-based column unlike our
generateCodeFrame.I tested this PR with #5647 and #4667.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).