Skip to content

fix: fsp.rm removing files does not take effect#16032

Merged
patak-cat merged 2 commits into
vitejs:mainfrom
btea:fix/remove-cache-dir
Apr 5, 2024
Merged

fix: fsp.rm removing files does not take effect#16032
patak-cat merged 2 commits into
vitejs:mainfrom
btea:fix/remove-cache-dir

Conversation

@btea
Copy link
Copy Markdown
Contributor

@btea btea commented Feb 26, 2024

Description

When I execute pnpm dev --debug to start the project, a cache file will be generated in the .vite folder, but when I type q in the terminal to exit the project, the terminal will output information about removing the cache, but the corresponding cache files are not deleted.

I tried to use fs.rmSync to replace fsp.rm and the corresponding cache file could be successfully deleted.

Additional context

I am not sure whether it is related to the operating environment. The above problems were encountered and solved in my local Windows environment, and the corresponding node version is v18.16.1.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants