docs: backend integration clarify tags to include in production HTML#16086
Merged
Conversation
|
|
patak-cat
reviewed
Mar 5, 2024
Contributor
Author
|
Thanks for the feedback! I agree, it's still useful to include an example template. I've modified it to fit in with the description more closely. Also I realized that each chunk can have multiple css files, and that both functions can be simplified to a single function which recursively gets the imported chunks. Let me know what you think of this. I feel the two examples and the description flow nicely together now. |
Contributor
Author
|
@patak-dev if you have a chance, can you take a look at the changes I made? Thanks! |
patak-cat
approved these changes
Mar 13, 2024
Member
patak-cat
left a comment
There was a problem hiding this comment.
Looks great, thanks for working on this!
sapphi-red
approved these changes
Mar 14, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While writing my own backend integration, the documentation wasn't clear to me what tags were required in generated HTML. After looking at what the vite build-html plugin does, and what a couple other integrations do, I wanted to update the documentation with what I found. I hope this clarifies how backends should interpret the manifest and what HTML tags they should generate.
Additional context
Some integrations recursively followed imports and included script tags for imported javascript chunks, and some included
<link rel="modulepreload">tags. Is there an official stance from the project on how imported javascript chunks should be included? I consider them optional since the entry point chunk's javascript imports any dependent javascript files anyways, so it'd just be an optimization.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).